Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

switch CCC on in Conversion Pattern recognition #6760

Merged
merged 1 commit into from Dec 4, 2014

Conversation

VinInn
Copy link
Contributor

@VinInn VinInn commented Dec 3, 2014

switch CCC on in Conversion Pattern recognition
For consistency with all other steps including Conversion Seeding itself.
At 50ns (Run2012C) the number of conversion candidates increases.
the regression becomes very small at electron/photon level

It was kept out of #5853 to disentangle technical changes from behavior modification

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 3, 2014

A new Pull Request was created by @VinInn (Vincenzo Innocente) for CMSSW_7_4_X.

switch CCC on in Conversion Pattern recognition

It involves the following packages:

RecoTracker/ConversionSeedGenerators

@cmsbuild, @nclopezo, @StoyanStoynev, @slava77 can you please review it and eventually sign? Thanks.
@ghellwig, @makortel, @GiacomoSguazzoni, @rovere, @VinInn, @appeltel, @gpetruc, @cerati, @dgulhan, @venturia this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 3, 2014

@slava77
Copy link
Contributor

slava77 commented Dec 3, 2014

... testing

@slava77
Copy link
Contributor

slava77 commented Dec 4, 2014

+1

for #6760 bb899ce
tested in CMSSW_7_4_X_2014-12-02-1400 (test area sign471)
The changes are as expected. Other than fairly small changes in convTrackCandidates and even smaller in allConversions, changes are pretty nonexistent.

Here is a summary of our tests:

  • timing, based on wflow 25202: about 10% decrease in convTrackCandidates CPU (0.15% of RECO)
  • visible increase in the number of conversionStepTracks and allConversions
  • very very small change in the PFCandidates

More details on conversionStepTracks and allConversions
In 1313 (dijet high-pt)
most of the increase is in 6 and 5-hit tracks
all_sign471vsorig_qcd13tevpt3ts3t5wf1313p0c_recotracks_conversionsteptracks__reco_obj_found

The amount of changes in conversionStepTracks is smaller in less dense events

  • most in 3 TeV dijet (+~5%)
  • pretty small in minbias (~<1%)
  • small in Photon2012B (few % up)
  • a few % up in 25ns ttbar PU35. Here the increase is most visible in the barrel-endcap overlap region
  • no changes in higher stat ele or photon gun events

@VinInn
Copy link
Contributor Author

VinInn commented Dec 4, 2014

ping

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 4, 2014

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_4_X IBs unless changes (tests are also fine). This pull request will be automatically merged.

cmsbuild added a commit that referenced this pull request Dec 4, 2014
switch CCC on in Conversion Pattern recognition
@cmsbuild cmsbuild merged commit 5431bdf into cms-sw:CMSSW_7_4_X Dec 4, 2014
@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 4, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants