Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RPC DQM occupancy plot bug fix for 73x #6763

Merged
merged 1 commit into from Dec 4, 2014

Conversation

acimmino
Copy link
Contributor

@acimmino acimmino commented Dec 3, 2014

RPC DQM occupancy plot bug fix for 73x

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 3, 2014

A new Pull Request was created by @acimmino (Anna Cimmino) for CMSSW_7_3_X.

RPC DQM occupancy plot bug fix for 73x

It involves the following packages:

DQM/RPCMonitorDigi

@cmsbuild, @danduggan, @nclopezo, @deguio can you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@nclopezo you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@deguio
Copy link
Contributor

deguio commented Dec 3, 2014

ciao anna,
it seems to me that this PR doesn't cover all the changes submitted for 72.
referring to: https://github.com/cms-sw/cmssw/pull/6619/files

is there a reason?
thanks,
F.

@acimmino
Copy link
Contributor Author

acimmino commented Dec 3, 2014

Dear Federico,

You're correct. The reason is that in 72X the RPC client modules are EDAnalyzers. In 73X and higher, the client modules are DQMEDHarvester. Plus, one bug I fixed and submitted in the PR 6619 was already fixed for 73X and higher. That is why, in this pull requests only a couple of lines of code were involved.

Ciao,
Anna


From: deguio [notifications@github.com]
Sent: 03 December 2014 17:47
To: cms-sw/cmssw
Cc: Anna Cimmino
Subject: Re: [cmssw] RPC DQM occupancy plot bug fix for 73x (#6763)

ciao anna,
it seems to me that this PR doesn't cover all the changes submitted for 72.
referring to: https://github.com/cms-sw/cmssw/pull/6619/files

is there a reason?
thanks,
F.


Reply to this email directly or view it on GitHubhttps://github.com//pull/6763#issuecomment-65443956.

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 4, 2014

@deguio
Copy link
Contributor

deguio commented Dec 4, 2014

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 4, 2014

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_3_X IBs unless changes (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @nclopezo, @ktf, @smuzaffar

@davidlange6
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 4, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants