Modify test so it is OK if class already loaded (rootmap) #6773
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
A new Pull Request was created by @wmtan for CMSSW_7_4_ROOT6_X. Modify test so it is OK if class already loaded (rootmap) It involves the following packages: FWCore/FWLite @cmsbuild, @Dr15Jones, @ktf, @nclopezo can you please review it and eventually sign? Thanks. |
|
ping |
ktf
added a commit
that referenced
this pull request
Dec 3, 2014
Modify test so it is OK if class already loaded (rootmap)
|
+1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A FWCore/FWLite unit test fails because, in a test of the loader, the test fails if the class is already loaded before the loader is invoked. Since the introduction of rootmap files in CMS, it is expected that the class will already be loaded. So this pull request simply modifies the test to return success in this case.
This test still has utility in ROOT 6 because it will still fail if the class is not loaded, so it serves as a test of the functionality of rootmap files.
Please merge this pull request as soon as convenient.