Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add a customisation fragment to check EventSetup usage #6783

Merged
merged 1 commit into from Dec 4, 2014
Merged

add a customisation fragment to check EventSetup usage #6783

merged 1 commit into from Dec 4, 2014

Conversation

fwyzard
Copy link
Contributor

@fwyzard fwyzard commented Dec 4, 2014

customiseCheckEventSetup:
customise a process to

  • print the list of ESSources and ESProducers
  • add a module to print all available EventSetup data
  • add a module to print all the used EventSetup data

PrintEventSetupContent:

  • migrate from legacy to 'one' module
  • reduce the number of LogSystem calls
  • add an option to make the output format consistent with that
    of PrintEventSetupDataRetrieval

PrintEventSetupDataRetrieval:

  • reduce the number of LogSystem calls

@fwyzard
add a customisation fragment to check EventSetup usage
926f6e3 
customiseCheckEventSetup:
customise a process to
  - print the list of ESSources and ESProducers
  - add a module to print all available EventSetup data
  - add a module to print all the used EventSetup data

PrintEventSetupContent:
  - migrate from legacy to 'one' module
  - reduce the number of LogSystem calls
  - add an option to make the output format consistent with that
    of PrintEventSetupDataRetrieval

PrintEventSetupDataRetrieval:
  - reduce the number of LogSystem calls
@cmsbuild cmsbuild added this to the Next CMSSW_7_4_X milestone Dec 4, 2014
@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 4, 2014

A new Pull Request was created by @fwyzard (Andrea Bocci) for CMSSW_7_4_X.

add a customisation fragment to check EventSetup usage

It involves the following packages:

FWCore/Modules

@cmsbuild, @Dr15Jones, @ktf, @nclopezo can you please review it and eventually sign? Thanks.
@wddgit, @wmtan this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.

@fwyzard
Copy link
Contributor Author

fwyzard commented Dec 4, 2014

adapted from a 2009 @Dr15Jones 's hypernews post and brought back to life ...

@Dr15Jones
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 4, 2014

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_4_X IBs unless changes or unless it breaks tests.

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 4, 2014

+1
Tested at: 926f6e3
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-6783/1432/summary.html

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 4, 2014

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_4_X IBs unless changes (tests are also fine). This pull request will be automatically merged.

cmsbuild added a commit that referenced this pull request Dec 4, 2014
@cmsbuild
Merge pull request #6783 from fwyzard/customiseCheckEventSetup
c55e40e 
add a customisation fragment to check EventSetup usage
@cmsbuild cmsbuild merged commit c55e40e into cms-sw:CMSSW_7_4_X Dec 4, 2014
@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 4, 2014

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-6783/1432/summary.html

@fwyzard fwyzard mentioned this pull request Dec 23, 2014
Merged
@fwyzard fwyzard deleted the customiseCheckEventSetup branch January 5, 2015 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
comparison-pending core-approved fully-signed tests-approved
Projects
None yet
Milestone
Next CMSSW_7_4_X
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@fwyzard @cmsbuild @Dr15Jones