TimeSlewSim fix for 74X #6787
Merged
TimeSlewSim fix for 74X #6787
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
A new Pull Request was created by @abdoulline for CMSSW_7_4_X. TimeSlewSim fix for 74X It involves the following packages: SimCalorimetry/HcalSimAlgos @cmsbuild, @civanch, @nclopezo, @mdhildreth can you please review it and eventually sign? Thanks. |
|
+1 |
|
This pull request is fully signed and it will be integrated in one of the next CMSSW_7_4_X IBs unless changes or unless it breaks tests. |
|
This pull request is fully signed and it will be integrated in one of the next CMSSW_7_4_X IBs unless changes (tests are also fine). This pull request will be automatically merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the bug introduced in HCAL digitization in 730pre2, which affects high-energy part of the spectrum (rechits with > 1 TeV in HB/HE, reducing their energy by factor 3-4). Not visible in regular QCD and TTbar samples, only noticeable in QCD_Pt_3000-3500 RelVal.
Private very-high-energy single-pion gun event-by-event tests and re-digi/re-reco of QCD_Pt_3000-3500 RelVal:
http://hep.baylor.edu/cmshcal/Validation/MC/730pre3_MCRUN2_73_V5-v1_TimeSlewFix_vs_730pre3_MCRUN2_73_V5-v1_noChange_RelVal/HighPtQCD/RecHits/RecHits_energy_HB.gif
show that the bug is fixed.