Fix SiStripDetInfoFileWriter::beginRun declaration and definition

[venturia]

Without this fix SiStripDetInfoFileWriter does not work. Apparently it has not been used for a very long time.

[cmsbuild]

A new Pull Request was created by @venturia for CMSSW_7_4_X.

Fix SiStripDetInfoFileWriter::beginRun declaration and definition

It involves the following packages:

CalibTracker/SiStripCommon

@diguida, @cerminar, @cmsbuild, @nclopezo, @rcastello, @mmusich can you please review it and eventually sign? Thanks.
@jlagram, @gbenelli this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.

[cmsbuild]

+1
Tested at: 1aa0dbd
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-6899/1600/summary.html

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-6899/1600/summary.html

[venturia]

ping

[diguida]

+1
sorry for the delay...

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_4_X IBs unless changes (tests are also fine). This pull request will be automatically merged.

[diguida]

@venturia the issue is that beginRun is a virtual method in the EDAnalyzer class. If you want to exploit polymorphism with function overriding, the signature of the function must be the same. With C++11, you can use the override keyword for such a check: think of a necessary condition for function overriding.

HTH