M tbtag #6966

silviodonato · 2014-12-18T12:45:29Z

This PR makes few b-tagging modules multi-thread friendly, as requested by HLT people (cc: @fwyzard).

With the PR:
"fillDescriptions" starts to be used in:
-JetTagProducer
-SecondaryVertexProducer
-SoftLepton
-TrackIPProducer

EDProducers are switched from legacy to edm::stream in:
-JetTagProducer
-FastPrimaryVertexWithWeightsProducer
-HLTDisplacedmumuVtxProducer
-HLTmumutkVtxProducer

The fillDescriptions have been filled following:
RecoBTag/SoftLepton/python/softMuonTagInfos_cfi.py

RecoBTag/SecondaryVertex/python/secondaryVertexTagInfos_cfi.py

ImpactParameter/python/impactParameterTagInfos_cfi.py

RecoBTau/JetTagComputer/python/ImpactParameter/python/ combinedMVABJetTags_cfi.py
RecoBTau/JetTagComputer/python/ImpactParameter/python/ positiveCombinedMVABJetTags_cfi.py
RecoBTau/JetTagComputer/python/ImpactParameter/python/ negativeCombinedMVABJetTags_cfi.py

cc: @aclebihan @arizzi @imarchesini @acaudron @ferencek @wddgit

Cheers,
Silvio.

cmsbuild · 2014-12-18T12:46:40Z

A new Pull Request was created by @silviodonato for CMSSW_7_4_X.

M tbtag

It involves the following packages:

HLTrigger/btau
RecoBTag/ImpactParameter
RecoBTag/SecondaryVertex
RecoBTag/SoftLepton
RecoBTau/JetTagComputer
RecoPixelVertexing/PixelVertexFinding

@perrotta, @cmsbuild, @nclopezo, @fwyzard, @Martin-Grunewald, @StoyanStoynev, @slava77 can you please review it and eventually sign? Thanks.
@imarches, @makortel, @acaudron, @GiacomoSguazzoni, @rovere, @VinInn, @appeltel, @ferencek, @cerati, @pvmulder, @dgulhan this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.

cmsbuild · 2014-12-18T13:30:49Z

-1
Tested at: 4552ffa
When I ran the RelVals I found an error in the following worklfows:
5.1 step1

runTheMatrix-results/5.1_TTbar+TTbarFS+HARVESTFS/step1_TTbar+TTbarFS+HARVESTFS.log
----- Begin Fatal Exception 18-Dec-2014 14:04:58 CET-----------------------
An exception of category 'Configuration' occurred while
   [0] Constructing the EventProcessor
   [1] Validating configuration of module: class=SecondaryVertexProducer label='ghostTrackVertexTagInfos'
Exception Message:
Illegal parameters found in configuration.  The parameters are named:
 'fitType'
 'maxFitChi2'
 'mergeThreshold'
You could be trying to use parameter names that are not
allowed for this plugin or they could be misspelled.
----- End Fatal Exception -------------------------------------------------

4.53 step3

runTheMatrix-results/4.53_RunPhoton2012B+RunPhoton2012B+HLTD+RECODreHLT+HARVESTDreHLT+MINIAODDreHLT/step3_RunPhoton2012B+RunPhoton2012B+HLTD+RECODreHLT+HARVESTDreHLT+MINIAODDreHLT.log
----- Begin Fatal Exception 18-Dec-2014 14:08:31 CET-----------------------
An exception of category 'Configuration' occurred while
   [0] Constructing the EventProcessor
   [1] Validating configuration of module: class=SecondaryVertexProducer label='ghostTrackVertexTagInfos'
Exception Message:
Illegal parameters found in configuration.  The parameters are named:
 'fitType'
 'maxFitChi2'
 'mergeThreshold'
You could be trying to use parameter names that are not
allowed for this plugin or they could be misspelled.
----- End Fatal Exception -------------------------------------------------

1000.0 step2

runTheMatrix-results/1000.0_RunMinBias2011A+RunMinBias2011A+TIER0+SKIMD+HARVESTDfst2+ALCASPLIT/step2_RunMinBias2011A+RunMinBias2011A+TIER0+SKIMD+HARVESTDfst2+ALCASPLIT.log
----- Begin Fatal Exception 18-Dec-2014 14:08:49 CET-----------------------
An exception of category 'Configuration' occurred while
   [0] Constructing the EventProcessor
   [1] Validating configuration of module: class=SecondaryVertexProducer label='ghostTrackVertexTagInfos'
Exception Message:
Illegal parameters found in configuration.  The parameters are named:
 'fitType'
 'maxFitChi2'
 'mergeThreshold'
You could be trying to use parameter names that are not
allowed for this plugin or they could be misspelled.
----- End Fatal Exception -------------------------------------------------

1306.0 step3

runTheMatrix-results/1306.0_SingleMuPt1_UP15+SingleMuPt1_UP15+DIGIUP15+RECOUP15+HARVESTUP15+MINIAODMCUP15/step3_SingleMuPt1_UP15+SingleMuPt1_UP15+DIGIUP15+RECOUP15+HARVESTUP15+MINIAODMCUP15.log
----- Begin Fatal Exception 18-Dec-2014 14:09:53 CET-----------------------
An exception of category 'Configuration' occurred while
   [0] Constructing the EventProcessor
   [1] Validating configuration of module: class=SecondaryVertexProducer label='ghostTrackVertexTagInfos'
Exception Message:
Illegal parameters found in configuration.  The parameters are named:
 'fitType'
 'maxFitChi2'
 'mergeThreshold'
You could be trying to use parameter names that are not
allowed for this plugin or they could be misspelled.
----- End Fatal Exception -------------------------------------------------

1001.0 step2

runTheMatrix-results/1001.0_RunMinBias2011A+RunMinBias2011A+TIER0EXP+ALCAEXP+ALCAHARVD/step2_RunMinBias2011A+RunMinBias2011A+TIER0EXP+ALCAEXP+ALCAHARVD.log
----- Begin Fatal Exception 18-Dec-2014 14:10:22 CET-----------------------
An exception of category 'Configuration' occurred while
   [0] Constructing the EventProcessor
   [1] Validating configuration of module: class=SecondaryVertexProducer label='ghostTrackVertexTagInfos'
Exception Message:
Illegal parameters found in configuration.  The parameters are named:
 'fitType'
 'maxFitChi2'
 'mergeThreshold'
You could be trying to use parameter names that are not
allowed for this plugin or they could be misspelled.
----- End Fatal Exception -------------------------------------------------

1003.0 step2

runTheMatrix-results/1003.0_RunMinBias2012A+RunMinBias2012A+RECODDQM+HARVESTDDQM/step2_RunMinBias2012A+RunMinBias2012A+RECODDQM+HARVESTDDQM.log
----- Begin Fatal Exception 18-Dec-2014 14:10:47 CET-----------------------
An exception of category 'Configuration' occurred while
   [0] Constructing the EventProcessor
   [1] Validating configuration of module: class=SecondaryVertexProducer label='ghostTrackVertexTagInfos'
Exception Message:
Illegal parameters found in configuration.  The parameters are named:
 'fitType'
 'maxFitChi2'
 'mergeThreshold'
You could be trying to use parameter names that are not
allowed for this plugin or they could be misspelled.
----- End Fatal Exception -------------------------------------------------

50101.0 step2

runTheMatrix-results/50101.0_SingleMuPt10_UP15ID+SingleMuPt10_UP15FSIDINPUT+SingleMuPt10FS_UP15_ID+HARVESTUP15FS/step2_SingleMuPt10_UP15ID+SingleMuPt10_UP15FSIDINPUT+SingleMuPt10FS_UP15_ID+HARVESTUP15FS.log
----- Begin Fatal Exception 18-Dec-2014 14:11:41 CET-----------------------
An exception of category 'Configuration' occurred while
   [0] Constructing the EventProcessor
   [1] Validating configuration of module: class=SecondaryVertexProducer label='ghostTrackVertexTagInfos'
Exception Message:
Illegal parameters found in configuration.  The parameters are named:
 'fitType'
 'maxFitChi2'
 'mergeThreshold'
You could be trying to use parameter names that are not
allowed for this plugin or they could be misspelled.
----- End Fatal Exception -------------------------------------------------

9.0 step3

runTheMatrix-results/9.0_Higgs200ChargedTaus+Higgs200ChargedTaus+DIGI+RECO+HARVEST/step3_Higgs200ChargedTaus+Higgs200ChargedTaus+DIGI+RECO+HARVEST.log
----- Begin Fatal Exception 18-Dec-2014 14:16:02 CET-----------------------
An exception of category 'Configuration' occurred while
   [0] Constructing the EventProcessor
   [1] Validating configuration of module: class=SecondaryVertexProducer label='ghostTrackVertexTagInfos'
Exception Message:
Illegal parameters found in configuration.  The parameters are named:
 'fitType'
 'maxFitChi2'
 'mergeThreshold'
You could be trying to use parameter names that are not
allowed for this plugin or they could be misspelled.
----- End Fatal Exception -------------------------------------------------

25.0 step3

runTheMatrix-results/25.0_TTbar+TTbar+DIGI+RECO+HARVEST+ALCATT/step3_TTbar+TTbar+DIGI+RECO+HARVEST+ALCATT.log
----- Begin Fatal Exception 18-Dec-2014 14:18:24 CET-----------------------
An exception of category 'Configuration' occurred while
   [0] Constructing the EventProcessor
   [1] Validating configuration of module: class=SecondaryVertexProducer label='ghostTrackVertexTagInfos'
Exception Message:
Illegal parameters found in configuration.  The parameters are named:
 'fitType'
 'maxFitChi2'
 'mergeThreshold'
You could be trying to use parameter names that are not
allowed for this plugin or they could be misspelled.
----- End Fatal Exception -------------------------------------------------

25202.0 step3

runTheMatrix-results/25202.0_TTbar_13+TTbar_13+DIGIUP15_PU25+RECOUP15_PU25+HARVESTUP15+MINIAODMCUP15/step3_TTbar_13+TTbar_13+DIGIUP15_PU25+RECOUP15_PU25+HARVESTUP15+MINIAODMCUP15.log
----- Begin Fatal Exception 18-Dec-2014 14:30:35 CET-----------------------
An exception of category 'Configuration' occurred while
   [0] Constructing the EventProcessor
   [1] Validating configuration of module: class=SecondaryVertexProducer label='ghostTrackVertexTagInfos'
Exception Message:
Illegal parameters found in configuration.  The parameters are named:
 'fitType'
 'maxFitChi2'
 'mergeThreshold'
You could be trying to use parameter names that are not
allowed for this plugin or they could be misspelled.
----- End Fatal Exception -------------------------------------------------

you can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-6966/1670/summary.html

silviodonato · 2014-12-18T15:00:12Z

Solved the error adding:

ghostTrackVertexTagInfos_cfi descriptions in TemplatedSecondaryVertexProducer.cc
pfImpactParameterTagInfos_cfi descriptions in IPProducer.cc

cmsbuild · 2014-12-18T15:04:45Z

Pull request #6966 was updated. @perrotta, @cmsbuild, @nclopezo, @fwyzard, @Martin-Grunewald, @StoyanStoynev, @slava77 can you please check and sign again.

slava77 · 2014-12-25T18:11:09Z

+1

for #6966 7ea2f58
tested in CMSSW_7_4_X_2014-12-18-0200 ( test area sign480)
I ran extra higher stat tests: there are no differences in monitored outputs (full DQM and fwlite reco products comparisons).

@ktf @nclopezo
Jenkins shows quite a few differences more typical for intel vs amd difference: could it be that the machinery stopped working?
Maybe an easy way to try is to rerun the jenkins tests again.

ktf · 2014-12-26T10:07:04Z

The machinery still works, what happened is that some nodes where
restarted / recreated and they ended up on a different hypervisor, but
labels with the actual architecture were not updated. I've now a rule
which checks for inconsistencies, however that will simply keep new
hosts offline. Unfortunately I cannot find any Jenkins plugin which
allows assigning labels based on a rule. Everything should be consistent
now.

@Degano we should add to the instructions about new nodes a comment
about making sure the CPU architecture labels are correct.

perrotta · 2014-12-29T12:17:03Z

+1

cmsbuild · 2014-12-29T12:18:07Z

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_4_X IBs unless changes (tests are also fine). This pull request will be automatically merged.

M tbtag

cmsbuild added this to the Next CMSSW_7_4_X milestone Dec 18, 2014

cmsbuild added comparison-pending hlt-pending pending-signatures reconstruction-pending tests-pending labels Dec 18, 2014

cmsbuild added comparison-pending hlt-pending pending-signatures reconstruction-pending tests-rejected and removed comparison-pending hlt-pending pending-signatures reconstruction-pending tests-pending labels Dec 18, 2014

cmsbuild added comparison-pending hlt-pending pending-signatures reconstruction-pending tests-pending and removed comparison-pending hlt-pending pending-signatures reconstruction-pending tests-rejected labels Dec 18, 2014

cmsbuild added hlt-pending pending-signatures reconstruction-pending tests-approved labels Dec 25, 2014

cmsbuild added comparison-available hlt-pending pending-signatures reconstruction-approved tests-approved and removed comparison-available hlt-pending pending-signatures reconstruction-pending tests-approved labels Dec 25, 2014

cmsbuild removed comparison-available hlt-pending pending-signatures reconstruction-approved tests-approved labels Dec 29, 2014

cmsbuild added comparison-available fully-signed hlt-approved reconstruction-approved tests-approved labels Dec 29, 2014

cmsbuild added a commit that referenced this pull request Dec 29, 2014

Merge pull request #6966 from silviodonato/MTbtag

0be3999

M tbtag

cmsbuild merged commit 0be3999 into cms-sw:CMSSW_7_4_X Dec 29, 2014

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

M tbtag #6966

M tbtag #6966

silviodonato commented Dec 18, 2014

cmsbuild commented Dec 18, 2014

cmsbuild commented Dec 18, 2014

silviodonato commented Dec 18, 2014

cmsbuild commented Dec 18, 2014

slava77 commented Dec 25, 2014

ktf commented Dec 26, 2014

perrotta commented Dec 29, 2014

cmsbuild commented Dec 29, 2014

M tbtag #6966

M tbtag #6966

Conversation

silviodonato commented Dec 18, 2014

cmsbuild commented Dec 18, 2014

cmsbuild commented Dec 18, 2014

silviodonato commented Dec 18, 2014

cmsbuild commented Dec 18, 2014

slava77 commented Dec 25, 2014

ktf commented Dec 26, 2014

perrotta commented Dec 29, 2014

cmsbuild commented Dec 29, 2014