Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ProductID problems when using an EDAlias #6989

Merged
merged 3 commits into from Dec 19, 2014

Conversation

Dr15Jones
Copy link
Contributor

The ProductID is used internally by edm::Ref's when doing a comparison. This comparison is used internally by AssociationMaps. Previously, an edm::Ref from an EDAlias had a different ProductID than the original which could cause lookups in AssociationMaps to fail.

-Remove the need for OtherThingAnalyzer.h
-added override
-made a stream::EDAnalyzer
Test that Refs produced from the original collection and Refs from an EDAlias are considered 'equal'.
The ProductID is used internally by edm::Ref's when doing a comparison. This comparison is used internally by AssociationMaps. Previously, an edm::Ref from an EDAlias had a different ProductID than the original which could cause lookups in AssociationMaps to fail.
@cmsbuild
Copy link
Contributor

A new Pull Request was created by @Dr15Jones (Chris Jones) for CMSSW_7_4_X.

Fix ProductID problems when using an EDAlias

It involves the following packages:

DataFormats/Provenance
FWCore/Framework
FWCore/Integration

@cmsbuild, @Dr15Jones, @ktf, @nclopezo can you please review it and eventually sign? Thanks.
@wddgit, @wmtan this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.

@Dr15Jones
Copy link
Contributor Author

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_4_X IBs unless changes or unless it breaks tests.

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_4_X IBs unless changes (tests are also fine). This pull request will be automatically merged.

cmsbuild added a commit that referenced this pull request Dec 19, 2014
Fix ProductID problems when using an EDAlias
@cmsbuild cmsbuild merged commit 06c608b into cms-sw:CMSSW_7_4_X Dec 19, 2014
@cmsbuild
Copy link
Contributor

@Dr15Jones Dr15Jones deleted the refToAlias branch January 23, 2015 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants