New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix ProductID problems when using an EDAlias #6989
Conversation
-Remove the need for OtherThingAnalyzer.h -added override -made a stream::EDAnalyzer
Test that Refs produced from the original collection and Refs from an EDAlias are considered 'equal'.
The ProductID is used internally by edm::Ref's when doing a comparison. This comparison is used internally by AssociationMaps. Previously, an edm::Ref from an EDAlias had a different ProductID than the original which could cause lookups in AssociationMaps to fail.
A new Pull Request was created by @Dr15Jones (Chris Jones) for CMSSW_7_4_X. Fix ProductID problems when using an EDAlias It involves the following packages: DataFormats/Provenance @cmsbuild, @Dr15Jones, @ktf, @nclopezo can you please review it and eventually sign? Thanks. |
+1 |
This pull request is fully signed and it will be integrated in one of the next CMSSW_7_4_X IBs unless changes or unless it breaks tests. |
This pull request is fully signed and it will be integrated in one of the next CMSSW_7_4_X IBs unless changes (tests are also fine). This pull request will be automatically merged. |
Fix ProductID problems when using an EDAlias
The ProductID is used internally by edm::Ref's when doing a comparison. This comparison is used internally by AssociationMaps. Previously, an edm::Ref from an EDAlias had a different ProductID than the original which could cause lookups in AssociationMaps to fail.