Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't expose TypeWithDict property mask #7002

Merged
merged 1 commit into from Dec 23, 2014

Conversation

wmtan
Copy link
Contributor

@wmtan wmtan commented Dec 23, 2014

In order to modify TypeWithDict so that it can handle types that are pointers or C-style arrays without header parsing, it is necessary to use additional bits in the property mask.
This means that user calls must not be allowed to arbitrarily set bits in the property mask. The property mask is currently an argument to several public constructors of TypeWithDict.
For each such public constructor, this pull request either removes it or makes it private. Only two lines of code outside the framework are affected.
Please merge this request as soon as convenient.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @wmtan for CMSSW_7_4_ROOT6_X.

Don't expose TypeWithDict property mask

It involves the following packages:

CommonTools/Utils
FWCore/Utilities

@nclopezo, @monttj, @cmsbuild, @Dr15Jones, @StoyanStoynev, @slava77, @vadler, @ktf can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @wddgit this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.

ktf added a commit that referenced this pull request Dec 23, 2014
Don't expose TypeWithDict property mask
@ktf ktf merged commit f8a1282 into cms-sw:CMSSW_7_4_ROOT6_X Dec 23, 2014
@ktf
Copy link
Contributor

ktf commented Dec 23, 2014

Root6. Bypassing.

@wmtan wmtan deleted the HidePropertyMask branch December 23, 2014 19:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants