Make ctors public, and remove unused argument #7033
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two constructors of TypeWithDict that should have been public were in fact private, just because they were not invoked from outside the class.
A carryover from 7_4_X in fireworks added the use of one of these ctor's, causing a compilation error and many link errors in fireworks.
Since there is no good reason for these ctor's not to be public, this pull request makes them public, thereby fixing the build errors.
The constructor not invoked from outside the class also had an unused argument removed, and the calls modified accordingly.
Please merge this pull request as soon as convenient.