Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make ctors public, and remove unused argument #7033

Merged
merged 1 commit into from Jan 2, 2015

Conversation

wmtan
Copy link
Contributor

@wmtan wmtan commented Jan 2, 2015

Two constructors of TypeWithDict that should have been public were in fact private, just because they were not invoked from outside the class.
A carryover from 7_4_X in fireworks added the use of one of these ctor's, causing a compilation error and many link errors in fireworks.
Since there is no good reason for these ctor's not to be public, this pull request makes them public, thereby fixing the build errors.
The constructor not invoked from outside the class also had an unused argument removed, and the calls modified accordingly.
Please merge this pull request as soon as convenient.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 2, 2015

A new Pull Request was created by @wmtan for CMSSW_7_4_ROOT6_X.

Make ctors public, and remove unused argument

It involves the following packages:

FWCore/Utilities

@cmsbuild, @Dr15Jones, @ktf, @nclopezo can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @wddgit this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.

ktf added a commit that referenced this pull request Jan 2, 2015
Make ctors public, and remove unused argument
@ktf ktf merged commit d6b21ef into cms-sw:CMSSW_7_4_ROOT6_X Jan 2, 2015
@wmtan wmtan deleted the MakeCtorPublic branch January 2, 2015 05:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants