New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PF-based b-taggers in the standard Reco #7041
PF-based b-taggers in the standard Reco #7041
Conversation
A new Pull Request was created by @ferencek (Dinko Ferencek) for CMSSW_7_4_X. PF-based b-taggers in the standard Reco It involves the following packages: FastSimulation/ParticleFlow @civanch, @nclopezo, @lveldere, @mdhildreth, @monttj, @cmsbuild, @StoyanStoynev, @slava77, @vadler can you please review it and eventually sign? Thanks. |
@cmsbuild please test |
please test |
The tests are being triggered in jenkins. |
@@ -0,0 +1,6 @@ | |||
import FWCore.ParameterSet.Config as cms | |||
|
|||
pfNegativeOnlyJetProbabilityBJetTags = cms.EDProducer("JetTagProducer", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure it's particularly practical to define so many almost identical cfi files.
If you decide to add some common parameters to JetTagProducer, the maintenance will be more costly than having one default and cloning with replace from it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For the JetTagProducers cloning would not be that useful since all parameters are typically updated. So these I won't modify.
+1 tested in CMSSW_7_4_X_2015-01-07-1000 (test area sign484) new products appear as expected from
the cost for AOD (ttbar PU35@25ns) is ~ 0.2%; |
@monttj |
…_7_4_X_2015-01-04-1400 PF-based b-taggers in the standard Reco
+1 |
This PR is the first step toward replacing the legacy with PF-based b-taggers. Here, the PF-based b-taggers are added to the standard Reco sequence alongside the legacy b-taggers. In subsequent PRs validation, PAT, etc. need to be switched to the PF-based taggers and finally the legacy taggers will be removed from the standard Reco sequence.
In the attached plots and in https://indico.cern.ch/event/359461/session/0/contribution/2/material/slides/0.pdf performance comparison between the legacy and PF-based taggers can be seen.
Legacy vs PF-based taggers from MiniAOD