Aligning jet correction services for non-AK4 algorithms with current JME...

[rappoccio]

Aligning jet correction services for non-AK4 algorithms with current JME recommendations. Was not properly propagated when the new constants were derived, so some users who used the CMSSW-based services applied the wrong corrections.

[cmsbuild]

A new Pull Request was created by @rappoccio for CMSSW_7_3_X.

Aligning jet correction services for non-AK4 algorithms with current JME...

It involves the following packages:

JetMETCorrections/Configuration

@cmsbuild, @vadler, @nclopezo, @monttj can you please review it and eventually sign? Thanks.
@TaiSakuma, @ahinzmann, @mmarionncern, @nhanvtran, @schoef, @mariadalfonso this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@nclopezo you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

[cmsbuild]

+1
Tested at: 8672ce3
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-7088/1781/summary.html

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-7088/1781/summary.html

[monttj]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_3_X IBs unless changes (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @nclopezo, @ktf, @smuzaffar

[davidlange6]

+1

[Martin-Grunewald]

@rappoccio

I belive this PR is responsible for the following problem I see in an HIon workflow:

# with command line options: RelVal --step=RAW2DIGI,L1Reco,RECO,DQM --conditions=auto:run2_data_HIon --filein=file:RelVal_HLT_HIon_DATA.root --custom_conditions= --fileout=RelVal_RECO_HIon_DATA.root --number=25 --data --no_exec --datatier SIM-RAW-HLT-RECO --eventcontent=RAW --customise=HLTrigger/Configuration/CustomConfigs.Base --customise=SLHCUpgradeSimulations/Configuration/postLS1Customs.customisePostLS1 --customise= --scenario=HeavyIons --python_filename=RelVal_RECO_HIon_DATA.py

namely:

%MSG
----- Begin Fatal Exception 14-Jan-2015 11:52:01 CET-----------------------
An exception of category 'ProductNotFound' occurred while
   [0] Processing run: 182838 lumi: 365 event: 13651230
   [1] Running path 'dqmoffline_step'
   [2] Calling event method for module L1FastjetCorrectorProducer/'ak4PFL1FastjetCorrector'
Exception Message:
Principal::getByToken: Found zero products matching all criteria
Looking for type: double
Looking for module label: fixedGridRhoFastjetAll
Looking for productInstanceName: 

   Additional Info:
      [a] If you wish to continue processing events after a ProductNotFound exce
ption,
add "SkipEvent = cms.untracked.vstring('ProductNotFound')" to the "options" PSet
 in the configuration.

----- End Fatal Exception -------------------------------------------------

[Martin-Grunewald]

Sorry, no, I take it back, it is in 74X.
Anyway all HIon workflows, such as 300/301/302, seem broken with the above error in 74X.

[davidlange6]

yes - seems most likely to be this one:

#6942
On Jan 14, 2015, at 3:44 PM, Martin Grunewald notifications@github.com
wrote:

Sorry, no, I take it back, it is in 74X.
Anyway all HIon workflows, such as 300/301/302, seem broken with the above error in 74X.

—
Reply to this email directly or view it on GitHub.