Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvements in finding class methods #7095

Merged
merged 1 commit into from Jan 8, 2015

Conversation

wmtan
Copy link
Contributor

@wmtan wmtan commented Jan 8, 2015

Some improvements in finding class methods in the cut parser and expression parser:

  1. Try first calling TClass::GetMethodWithPrototype(), which finds the best match function in the class or its base classes if the signature is correct.
  2. Don't reject functions found in a base class from the result of TClass::GetMethodWithPrototype().
  3. Cache the results, so this function is called at most once for any specific member function.
    Includes two other minor improvements in TypeWithDict.
    Please merge this request as soon as convenient.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 8, 2015

A new Pull Request was created by @wmtan for CMSSW_7_4_ROOT6_X.

Improvements in finding class methods

It involves the following packages:

CommonTools/Utils
FWCore/Utilities

@nclopezo, @cvuosalo, @monttj, @cmsbuild, @Dr15Jones, @slava77, @vadler, @ktf can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @wddgit this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.

davidlt added a commit that referenced this pull request Jan 8, 2015
Improvements in finding class methods
@davidlt davidlt merged commit ea5d23d into cms-sw:CMSSW_7_4_ROOT6_X Jan 8, 2015
@wmtan wmtan deleted the ClassMethodFinding branch January 8, 2015 23:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants