Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid duplicate dataset names between lhe and hadronization step in gen-only relvals #7101

Closed
wants to merge 1 commit into from

Conversation

bendavid
Copy link
Contributor

@bendavid bendavid commented Jan 9, 2015

Suffering here from a historically confusing use of "GEN" datatier for lhe event content. Therefore we cannot use the "GEN" datatier for the gen-only output of the hadronization step.

Minimal solution is to use "GEN-SIM" datatier for gen-only output.

Addresses the issue reported by Alan here
https://hypernews.cern.ch/HyperNews/CMS/get/wmDevelopment/642/1/1/1/1/1/1/2/1/1/1/1/1/1/1/1/1/1/1/1/1/1.html

@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 9, 2015

A new Pull Request was created by @bendavid (Josh Bendavid) for CMSSW_7_4_X.

Avoid duplicate dataset names between lhe and hadronization step in gen-only relvals

It involves the following packages:

Configuration/PyReleaseValidation

@cmsbuild, @srimanob, @nclopezo, @boudoul, @franzoni can you please review it and eventually sign? Thanks.
@ghellwig, @Martin-Grunewald this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

@franzoni
Copy link

hi Josh @bendavid , I overlooked this PR and placed #7201, which achieves the same goal.
Feel free to close this one.

@bendavid
Copy link
Contributor Author

Might it not be preferable to modify the tier consistently for all workflows (as opposed to just the two step ones)?

@franzoni
Copy link

That's like saying GEN disappears as data tier, and we only use GEN-SIM for everything ?
Let's not do that.

@bendavid
Copy link
Contributor Author

No, that's saying that the GEN datatier is reserved exclusively for the LHE event content, for which it's already being used in production.

Hadronized output is quite different from just the LHE output (and indeed requires to use RAWSIM event content to get everything consistent)

@franzoni
Copy link

franzoni commented Feb 3, 2015

Hi Josh @bendavid , we agreed in conversation we would solve this by cleanly asking EDMLHE to be introduced. At that stage, we would even be in position of un-doing #7201, which is solving the problem with a sufficient hack now. Can we close this ?

@davidlange6 davidlange6 closed this Feb 3, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants