Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Qg small updates #7166

Merged
merged 4 commits into from
Jan 14, 2015
Merged

Qg small updates #7166

merged 4 commits into from
Jan 14, 2015

Conversation

tomcornelis
Copy link
Contributor

These are a couple of small finalizing updates, following up to two bigger pull requests #7057 and #6931

  • Change the product names of QGTagger.cc from axis2Likelihood, ptDLikelihood and multLikelihood to simply axis2, ptD and mult, because the former could be confusing
  • Skip (very rare) jets with 2 or less particles (we need to have at least 3 particles to calculate a non-zero axis2).
  • Provide the cfi fragment with default fragments, as was requested. Also "cmsRun jettoolbox_cfg.py" will work perfectly once I have the payloads uploaded to the database.

UAEDF-tomc added 4 commits January 14, 2015 16:09
@cmsbuild
Copy link
Contributor

A new Pull Request was created by @UAEDF-tomc (Tom Cornelis) for CMSSW_7_4_X.

Qg small updates

It involves the following packages:

RecoJets/JetProducers

@cmsbuild, @cvuosalo, @nclopezo, @slava77 can you please review it and eventually sign? Thanks.
@rappoccio, @ahinzmann, @TaiSakuma, @yslai, @nhanvtran, @schoef, @mariadalfonso this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.

@cvuosalo
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

@cvuosalo
Copy link
Contributor

+1

For #7166 14922e94f

Minor clean-up changes related to #7057 (the addition of a new weight for
likelihood variables).

Code changes are satisfactory.

Test of new functionality confirms that new likelihood variables are populated with reasonable values.

Jenkins tests CMSSW_7_4_X_2015-01-14-1400:
compilation, unit tests, matrix tests, static checks are all OK.

As expected, there are no differences compared to the baseline in the
following:

alternative-comparisons
(after stripping false positives like timer data)

and

validateJR

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_4_X IBs unless changes (tests are also fine). This pull request will be automatically merged.

cmsbuild added a commit that referenced this pull request Jan 14, 2015
@cmsbuild cmsbuild merged commit 3dacaf2 into cms-sw:CMSSW_7_4_X Jan 14, 2015
@tomcornelis tomcornelis deleted the qgSmallUpdates branch April 13, 2018 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants