Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pixel updates #7167

Closed
wants to merge 2 commits into from
Closed

Pixel updates #7167

wants to merge 2 commits into from

Conversation

clelange
Copy link
Contributor

During the switch from CVS to git a large part of the pixel code additions which are needed for the pixel online software and also calibration of the pixel detector were forgotten to be added to a release and only ended up in the CVS head. These changes should be in CMSSW_5_3_X and later (pull requests will follow for CMSSW_7_X_Y).

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @clelange for CMSSW_5_3_X.

Pixel updates

It involves the following packages:

CalibFormats/SiPixelObjects

@diguida, @cerminar, @cmsbuild, @nclopezo, @rcastello, @mmusich can you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@smuzaffar you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@cmsbuild
Copy link
Contributor

@mmusich
Copy link
Contributor

mmusich commented Mar 9, 2015

@clelange do you still need this for 53X?

@clelange
Copy link
Contributor Author

clelange commented Mar 9, 2015

Yes, would be nice to have, since 5_3_X is still the standard for some systems in the CMS online cluster.

@mmusich
Copy link
Contributor

mmusich commented Mar 9, 2015

@cmsbuild please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 9, 2015

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 9, 2015

@diguida
Copy link
Contributor

diguida commented Mar 24, 2015

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_5_3_X IBs unless changes (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @smuzaffar, @ktf

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants