Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix layer Removal #7184

Merged
merged 6 commits into from Jan 16, 2015
Merged

Fix layer Removal #7184

merged 6 commits into from Jan 16, 2015

Conversation

boudoul
Copy link
Contributor

@boudoul boudoul commented Jan 15, 2015

The PR #7131 was by mistake not removing the right layer , this should fix this (removing the first layer of the outer Barrel)

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @boudoul (boudoul) for CMSSW_6_2_X_SLHC.

Fix layer Removal

It involves the following packages:

Geometry/TrackerCommonData
Geometry/TrackerRecoData
Geometry/TrackerSimData
SLHCUpgradeSimulations/Configuration
SLHCUpgradeSimulations/Geometry

@civanch, @Dr15Jones, @ianna, @mdhildreth, @cmsbuild, @nclopezo, @ktf can you please review it and eventually sign? Thanks.
@makortel, @Martin-Grunewald, @ghellwig, @VinInn this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@fratnikov, @mark-grimes you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@mark-grimes
Copy link

No point triggering automatic tests since this is not tested by them. I'll perform some 146xx tests privately.

@cmsbuild
Copy link
Contributor

@mark-grimes
Copy link

merge

14600 and 14661 also fine

cmsbuild added a commit that referenced this pull request Jan 16, 2015
@cmsbuild cmsbuild merged commit 6d156f8 into cms-sw:CMSSW_6_2_X_SLHC Jan 16, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants