Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase Method2 overlapping pulse limit #7210

Merged

Conversation

mark-grimes
Copy link

Increases the criterion for deciding whether two (or three) pulses are overlapping or not. I think it would be better to have this user configurable but there will be a review of this fit code in the next few days anyway.

The reason for choosing 10 ns is discussed on #7174 with a plot.

@sabrandt, @hengne

@mark-grimes
Copy link
Author

merge

Skipping tests for trivial change

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @mark-grimes (Mark Grimes) for CMSSW_6_2_X_SLHC.

Increase Method2 overlapping pulse limit

It involves the following packages:

RecoLocalCalo/HcalRecAlgos

@cmsbuild, @cvuosalo, @nclopezo, @slava77 can you please review it and eventually sign? Thanks.
@argiro this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@fratnikov, @mark-grimes you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

cmsbuild added a commit that referenced this pull request Jan 16, 2015
@cmsbuild cmsbuild merged commit 9340a13 into cms-sw:CMSSW_6_2_X_SLHC Jan 16, 2015
@mark-grimes mark-grimes deleted the increaseOverlappingPulseLimit branch January 16, 2015 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants