Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve Clang issues in HLTrigger/btau #7216

Merged
merged 2 commits into from
Jan 16, 2015

Conversation

davidlt
Copy link
Contributor

@davidlt davidlt commented Jan 16, 2015

The patchset resolves 1 error and another 2 warnings while building with Clang.

Build tested with GCC 4.9.1 and Clang pre-3.6 (65d8b4c) in DEVEL IB.

David Abdurachmanov added 2 commits January 16, 2015 12:07
`HLTJetTagWithMatching<T>::findCSV` last argument `minDr` has a default
value specified in definition. The default arguments are specified in
declaration. The patch resolves this issue.

Signed-off-by: David Abdurachmanov <David.Abdurachmanov@cern.ch>
Signed-off-by: David Abdurachmanov <David.Abdurachmanov@cern.ch>
@cmsbuild
Copy link
Contributor

A new Pull Request was created by @davidlt for CMSSW_7_4_X.

Resolve Clang issues in HLTrigger/btau

It involves the following packages:

HLTrigger/btau

@Martin-Grunewald, @perrotta, @cmsbuild, @nclopezo, @fwyzard can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @ferencek, @acaudron, @pvmulder, @imarches this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.

@perrotta
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_4_X IBs unless changes (tests are also fine). This pull request will be automatically merged.

cmsbuild added a commit that referenced this pull request Jan 16, 2015
@cmsbuild cmsbuild merged commit 8c7e766 into cms-sw:CMSSW_7_4_X Jan 16, 2015
@cmsbuild
Copy link
Contributor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants