FSQ DQM update for 7_4 series

[fruboes]

Contains the following changes:

• All development from Update FSQ DQM #6942 (reverted PR)
• Fixes from TriggerResultFilters: accept arbitrary Path names #7108 (reverted PR)
• Fix for a crash in HI workflow (missing products needed to apply JEC). Fix disables corrected jets production and most of FSQ trigger DQM histograms. The only histograms left (or planned to be added in the future in FSQ trigger DQM) for the HI workflow are for minbias like paths (currently ZeroBias+ single pixel track trigger)

Testing was done in a normall (non-HI) workflow with edm file missing the same product as in HI case.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-7267/2004/summary.html

[deguio]

+1
many thanks @fruboes

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_4_X IBs unless changes (tests are also fine). This pull request will be automatically merged.

[ktf]

Looks like we still have a few LogError related to this:

%MSG-e DQMGenericClient:  DQMGenericClient:fsqClient@endJob  21-Jan-2015 09:46:35 CET
PostEndRun DQMGenericClient::findAllSubdirectories ==> Missing folder HLT/FSQ !!!

for example in step 5 of:

• 8.0
• 7.0
• 4.22
• 1308.0
• 1307.0

@fruboes can you have a look?

[fruboes]

Dear @ktf,

could you give me a more beginner friendly explanation of the part starting with "for example" of your message :) ?

When it comes to error messages - is this only for HI workflow? If yes, this most likely comes from the fact that minbias like triggers are not yet in HI menu (but still I need to look, now I dont know where to find them/how to reproduce)

cheers,
Tomasz

[deguio]

ciao @fruboes
the number mentioned by @ktf are the reference to the runTheMatrix workflow.
you can run them and reproduce the error with

runTheMatrix -l 8.0, 7.0, 4.22, .............

you should be able to find the same errors in the log saved locally.

[deguio]

it is what is run automatically in the jenkins tests. you can access the logs at:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-7267/2004/runTheMatrix-results/4.22_RunCosmics2011A+RunCosmics2011A+RECOCOSD+ALCACOSD+SKIMCOSD+HARVESTDC/step5_RunCosmics2011A+RunCosmics2011A+RECOCOSD+ALCACOSD+SKIMCOSD+HARVESTDC.log

[deguio]

and no... it comes for other WF as well. the ones run automatically are accessible at:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-7267/2004/runTheMatrix-results/

ciao,
F.

[ktf]

Thank you Fede for all the explanations and sorry to @fruboes for the cryptic message.

[fruboes]

Thanks for the explanation! It looks like the problem is visible only for cosmics workflows. In step3 DQMOffline/Configuration/python/DQMOfflineCosmics_cff.py file is used, where there is no FSQ dqm source module included (which is correct I guess). Than in step5 fsq client module is included from StandardSequences/python/HarvestingCosmics_cff.py (through HLTriggerOffline.Common.HLTValidationHarvest_cff).

I guess the correct fix would be to modify the HarvestingCosmics_cff.py in such way the FSQ client module doesnt get called. Please confirm, that this is the right way to go, if so I'll make the fix,

Cheers,
Tomasz

[deguio]

hello @fruboes
what you wrote makes sense.
since this PR has been merged, the changes will have to be submitted with a new one.
thanks,
F.

[fruboes]

Done - see #7321

Tomasz