Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Performance improvement in PAT helpers.py (70X) #727

Merged
merged 2 commits into from Sep 14, 2013
Merged

Performance improvement in PAT helpers.py (70X) #727

merged 2 commits into from Sep 14, 2013

Conversation

makortel
Copy link
Contributor

@makortel makortel commented Sep 6, 2013

Remove unnecessary copying in PAT helpers.MassSearchReplaceAnyInputTagVisitor. This can result a significant speedup in configuration parsing depending how many times massSearchReplaceAnyInputTag() function is called. Results identical dump (process.dumpPython()) in my tests. Also add unit test for the function.

PR #723 was based on these commits.

@makortel
Added unit test for helpers.massSearchReplaceAnyInputTag()
89fa7c9
@makortel
Remove unnecessary object copying in helpers.MassSearchReplaceAnyInpu…
2c89f7a 
…tTagVisitor()

According to help(cms.PSet) parameters_() copies all the contained
parameter objects, while in this case it is enough to iterate over the
names.
@makortel makortel mentioned this pull request Sep 6, 2013
Merged
@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 6, 2013

A new Pull Request was created by @makortel (Matti Kortelainen) for CMSSW_7_0_X.

Performance improvement in PAT helpers.py (70X)

It involves the following packages:

PhysicsTools/PatAlgos

@vadler can you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.

@nclopezo
Copy link
Contributor

Hi,

I ran the usual tests on top of CMSSW_7_0_X_2013-09-11-0200, all tests passed:

https://cmssdt.cern.ch/jenkins/job/Pull-Request-Integration/ARCHITECTURE=slc5_amd64_gcc481/452/console

you can see the artifacts here:

https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/452

@ktf
Copy link
Contributor

ktf commented Sep 12, 2013

@vadler

ping?

@vadler
Copy link

vadler commented Sep 14, 2013

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next IBs unless changes or unless it breaks tests. @ktf can you please take care of it?

ktf added a commit that referenced this pull request Sep 14, 2013
@ktf
Merge pull request #727 from makortel/pathelpers
844b9e8 
Performance improvement in PAT helpers.py (70X)
@ktf ktf merged commit 844b9e8 into cms-sw:CMSSW_7_0_X Sep 14, 2013
@makortel makortel deleted the pathelpers branch October 20, 2016 10:15
jniedzie pushed a commit to jniedzie/cmssw that referenced this pull request May 16, 2018
@gpetruc
Merge pull request cms-sw#727 from steggema/heppy_94X_dev_Ele2017MVAfix
0ae39a6 
Minor fix to 2017 electron MVA evaluation, plus add relevant E/Gamma code
@makortel makortel restored the pathelpers branch October 9, 2023 14:29
@makortel makortel deleted the pathelpers branch October 9, 2023 14:29
@makortel makortel restored the pathelpers branch October 9, 2023 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
analysis-approved fully-signed
Projects
None yet
Milestone
CMSSW_7_0_0_pre4
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@makortel @cmsbuild @nclopezo @ktf @vadler