New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bump to v3 of both hf SL #7290
bump to v3 of both hf SL #7290
Conversation
A new Pull Request was created by @davidlange6 (David Lange) for CMSSW_7_4_X. bump to v3 of both hf SL It involves the following packages: FastSimulation/Calorimetry @cmsbuild, @civanch, @nclopezo, @mdhildreth, @lveldere can you please review it and eventually sign? Thanks. |
great, thanks David |
+1 |
+1 |
This pull request is fully signed and it will be integrated in one of the next CMSSW_7_4_X IBs unless changes or unless it breaks tests. |
This pull request is fully signed and it will be integrated in one of the next CMSSW_7_4_X IBs unless changes (but tests are reportedly failing). |
Test fails because new file is not yet available to jenkins (cms-sw/cmsdist#1300 not yet in the IB) |
there is no physics difference between v2 and v3 - just a technical performance one. This PR needs a corresponding CMSDIST change to go in first
New configuration for the shower libraries:
compressed with lzma level 4
on output, baskets are flushed every 50 events.
This unfortunately gives back the size improvement realized with v2, but does improve by a factor of 3 the speed of the v1 libraries which is of particular benefit to fastsim.