Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fastsim cmsdriver digirecomix #7306

Merged
merged 7 commits into from Jan 26, 2015
Merged

Fastsim cmsdriver digirecomix #7306

merged 7 commits into from Jan 26, 2015

Conversation

lveldere
Copy link
Contributor

All FullSim cmsDriver pileup options are now available for FastSim, automatically.
FastSim specific pile-up options no longer exist.
Except that Gen-mixing is requested by prepending the pu option with 'GEN_'

FastSim runTheMatrix wfs were updated to this new syntax

this pr builds on #7302
review will be easier when that one is merged.

wfs 5.1, 135.1, 25400.0 run

changes will be scrutinised further the next days,
and possible cfg mistakes will be fixed in

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @lveldere for CMSSW_7_4_X.

Fastsim cmsdriver digirecomix

It involves the following packages:

Configuration/Applications
Configuration/PyReleaseValidation
Configuration/StandardSequences
FastSimulation/Configuration
FastSimulation/ParticleFlow
FastSimulation/PileUpProducer
FastSimulation/Tracking

@civanch, @nclopezo, @lveldere, @boudoul, @franzoni, @mdhildreth, @cmsbuild, @srimanob, @davidlange6 can you please review it and eventually sign? Thanks.
@ghellwig, @Martin-Grunewald, @makortel, @GiacomoSguazzoni, @rovere, @VinInn, @appeltel, @matt-komm, @cerati, @dgulhan this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.

@lveldere
Copy link
Contributor Author

@cmsbuild

can you please initiate tests?

- correct label for pileup information in case of gen-level mixing
@ghost
Copy link

ghost commented Jan 22, 2015

@cmsbuild please test

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

@lveldere
Copy link
Contributor Author

@pdmv @operations, please review

@davidlange6
Copy link
Contributor

+1

we usually do after others sign (which happened 5 hours ago..)

@davidlange6
Copy link
Contributor

bypassing this PR in for pre6 - please bring up any issues as needed (I don't see any pending)

davidlange6 added a commit that referenced this pull request Jan 26, 2015
@davidlange6 davidlange6 merged commit d70c3e6 into cms-sw:CMSSW_7_4_X Jan 26, 2015
@lveldere lveldere deleted the fastsim-cmsdriver-digirecomix branch January 29, 2015 20:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants