Add option to switch between hierarchy and averaging constraints in MP-b... #7320
Conversation
…P-based tracker alignment The default behaviour is now to use averaging constraints after problems with the fit convergence have been found when using hierarchy constraints. This is explained in more detail in this presentation by C. Kleinwort, https://indico.cern.ch/event/337178/session/0/contribution/5/material/slides/0.pdf Note that the implementation of the averaging constraints is still approximate for the time being, but adequate for current purposes and superior to the current version of the hierarchy constraints.
|
A new Pull Request was created by @mschrode (Matthias Schroeder) for CMSSW_7_1_X. Add option to switch between hierarchy and averaging constraints in MP-b... It involves the following packages: Alignment/CommonAlignmentAlgorithm @diguida, @cerminar, @cmsbuild, @nclopezo, @rcastello, @mmusich can you please review it and eventually sign? Thanks. |
|
@cmsbuild please test |
|
The tests are being triggered in jenkins. |
cmsbuild
added
alca-pending
comparison-available
orp-pending
and removed
alca-pending
comparison-pending
orp-pending
pending-signatures
tests-approved
labels
|
I can't think of why think would be needed in 71x. Is there a use case? |
|
@davidlange6 : If you can guarantee that there will never be a need or request to run alignment on any data/MC on 71x, then I agree. If you cannot give this guarantee, please merge in. |
|
+1 |
|
This pull request is fully signed and it will be integrated in one of the next CMSSW_7_1_X IBs unless changes (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar |
|
+1 |
Add option to switch between hierarchy and averaging constraints in MP-b...
...ased tracker alignment
The default behaviour is now to use averaging constraints after
problems with the fit convergence have been found when using
hierarchy constraints. This is explained in more detail in this
presentation by C. Kleinwort,
https://indico.cern.ch/event/337178/session/0/contribution/5/material/slides/0.pdf
Note that the implementation of the averaging constraints is still
approximate for the time being, but adequate for current purposes
and superior to the current version of the hierarchy constraints.
This PR backports #6254 to 71X.