Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New Global Tags for Release Validation in all the supported scenarios. #7339

Merged
merged 1 commit into from
Jan 23, 2015
Merged

New Global Tags for Release Validation in all the supported scenarios. #7339

merged 1 commit into from
Jan 23, 2015

Conversation

diguida
Copy link
Contributor

@diguida diguida commented Jan 23, 2015

The new key run2_mc_hi for validation of HI simulation in Run2 is added.
The new Global Tags contain new Records for Magnetic Field geometry and configuration, for extended Muon APE, and (in Run2 only) fixes the Ideal simulation geometry and adds new development scenarios.

@cmsbuild cmsbuild added this to the Next CMSSW_7_4_X milestone Jan 23, 2015
@cmsbuild
Copy link
Contributor

A new Pull Request was created by @diguida (Salvatore Di Guida) for CMSSW_7_4_X.

New Global Tags for Release Validation in all the supported scenarios.

It involves the following packages:

Configuration/AlCa

@diguida, @cerminar, @cmsbuild, @nclopezo, @rcastello, @mmusich can you please review it and eventually sign? Thanks.
@ghellwig, @Martin-Grunewald this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.

@diguida diguida mentioned this pull request Jan 23, 2015
Closed
@davidlange6
Copy link
Contributor

do these GTs work without #6978?

@diguida
Copy link
Contributor Author

diguida commented Jan 23, 2015

@davidlange6 yes, they contain new records for condition objects: given that no new consumers are activated yet, they are not loaded.
Anyhow, let's see if we can include #6978 in the pre-release to come, as I wrote privately tonight GVA time...

@slava77
Copy link
Contributor

slava77 commented Jan 23, 2015

will these changes in GT introduce changes in digi-reco?
(the easiest testing of 6x6 APE payloads for us would be to be able to show identical results incrementally; if the GT before and after introduces changes in more payloads, it becomes less trivial).

I think we should integrate this PR, after that #6978 can be tested incrementally (it will also not need additional updates, just need this PR in IB)

@davidlange6
Copy link
Contributor

please test

On Jan 23, 2015, at 6:02 AM, Salvatore Di Guida <notifications@github.commailto:notifications@github.com> wrote:

The new key run2_mc_hi for validation of HI simulation in Run2 is added.
The new Global Tags contain new Records for Magnetic Field geometry and configuration, for extended Muon APE, and (in Run2 only) fixes the Ideal simulation geometry and adds new development scenarios.

You can view, comment on, or merge this pull request online at:

#7339

Commit Summary

  • New Global Tags for Release Validation in all the supported scenarios.

File Changes

Patch Links:

—
Reply to this email directly or view it on GitHubhttps://github.com//pull/7339.

@diguida
Copy link
Contributor Author

diguida commented Jan 23, 2015

@slava77
The changes w.r.t. to the latest pre-release are being documented here (I am updating the page now). I can tell you one by one the effect on DIGI-RECO:

  • Run1 simulations:
    • Magnetic field geometry and configuration: this implies that the MF maps are read not from release, but from DB. The addition has no effect as the consumers are still not activated; once they are on, they should have no impact (otherwise it is a bug).
    • Muon extended APE: this is what should give identical results in Migration to 6x6 APE matrix in alignment and RECO #6978
  • Run2 simulations:
    • Fix of the Ideal and ZeroMaterial SIM geometry: no effect on DIGI-RECO.
    • New development SIM geometry scenarios: no effect on DIGI-RECO.
    • Magnetic field geometry and configuration: this implies that the MF maps are read not from release, but from DB. The addition has no effect as the consumers are still not activated; once they are on, they should have no impact (otherwise it is a bug).
    • Muon extended APE: this is what should give identical results in Migration to 6x6 APE matrix in alignment and RECO #6978
    • New Reco BS, actually introduced by NominalCollision2015 beamspot: migration of SIM and RECO BS #7288 : this makes the SIM and RECO BS consistent (before we were recycling the old GEN-SIM with old SIM BS, so we had to keep it in sync): this has effect on DIGI-RECO if you run on different GEN-SIM.
    • For startup. fix of the EE misalignment to be pessimistic (was set to ideal by mistake in 73X).

@diguida
Copy link
Contributor Author

diguida commented Jan 23, 2015

@slava77 continued...

  • Run1/2 data and HLT:
    • Magnetic field geometry and configuration: this implies that the MF maps are read not from release, but from DB. The addition has no effect as the consumers are still not activated; once they are on, they should have no impact (otherwise it is a bug).
    • Muon extended APE: this is what should give identical results in Migration to 6x6 APE matrix in alignment and RECO #6978

@slava77
Copy link
Contributor

slava77 commented Jan 23, 2015

Hi Salvatore,

Thank you for the details.
Thanks for the reminder of #7288.
Considering that #7288 is in, we can't run tests which reuse gen-sim
on the pre-release and should make it on the latest IB.

From your description, it looks like as long as we use the latest IB for
tests,
then addition of this PR shouldn't change DIGI-RECO outputs.

On 1/23/15 8:57 AM, Salvatore Di Guida wrote:

@slava77 https://github.com/slava77
The changes w.r.t. to the latest pre-release are being documented here
https://twiki.cern.ch/twiki/bin/viewauth/CMS/RelValGT (I am updating
the page now). I can tell you one by one the effect on DIGI-RECO:

—
Reply to this email directly or view it on GitHub
#7339 (comment).

Vyacheslav (Slava) Krutelyov
TAMU: Physics Dept Texas A&M MS4242, College Station, TX 77843-4242
CERN: 42-R-027
AIM/Skype: siava16 googleTalk: slava77@gmail.com
(630) 291-5128 Cell (US) +41 76 275 7116 Cell (CERN)

@diguida
Copy link
Contributor Author

diguida commented Jan 23, 2015

@slava77
When you say

the easiest testing of 6x6 APE payloads for us would be to be able to show identical results incrementally
...
after this PR is integrated, #6978 can be tested incrementally

I assume that the incremental test you want to do is the following:

  1. you run the tests with the new GT in the latest IB, and check the output: this should not give you changes in DIGI-RECO (apart EE in Run2 startup due to misalignment) as the additional records are not consumed, and the old ones are kept unchanged.
  2. you then run the tests with the new GT on top of Migration to 6x6 APE matrix in alignment and RECO #6978 : it should return the same values.

@diguida
Copy link
Contributor Author

diguida commented Jan 23, 2015

+1
Short matrix test on the latest IB CMSSW_7_4_X_2015-01-23-0200 are ok:

4.22_RunCosmics2011A+RunCosmics2011A+RECOCOSD+ALCACOSD+SKIMCOSD+HARVESTDC Step0-PASSED Step1-PASSED Step2-PASSED Step3-PASSED Step4-PASSED  - time date Fri Jan 23 15:26:14 2015-date Fri Jan 23 15:15:09 2015; exit: 0 0 0 0 0
4.53_RunPhoton2012B+RunPhoton2012B+HLTD+RECODreHLT+HARVESTDreHLT+MINIAODDreHLT Step0-PASSED Step1-PASSED Step2-PASSED Step3-PASSED Step4-PASSED  - time date Fri Jan 23 15:47:19 2015-date Fri Jan 23 15:15:11 2015; exit: 0 0 0 0 0
5.1_TTbar+TTbarFS+HARVESTFS Step0-PASSED Step1-PASSED  - time date Fri Jan 23 15:24:25 2015-date Fri Jan 23 15:15:15 2015; exit: 0 0
8.0_BeamHalo+BeamHalo+DIGICOS+RECOCOS+ALCABH+HARVESTCOS Step0-PASSED Step1-PASSED Step2-PASSED Step3-PASSED Step4-PASSED  - time date Fri Jan 23 15:26:16 2015-date Fri Jan 23 15:15:19 2015; exit: 0 0 0 0 0
25.0_TTbar+TTbar+DIGI+RECO+HARVEST+ALCATT Step0-PASSED Step1-PASSED Step2-PASSED Step3-PASSED Step4-PASSED  - time date Fri Jan 23 15:53:54 2015-date Fri Jan 23 15:24:32 2015; exit: 0 0 0 0 0
135.4_ZEE_13+ZEEFS_13+HARVESTUP15FS+MINIAODMCUP15FS Step0-PASSED Step1-PASSED Step2-PASSED  - time date Fri Jan 23 15:39:38 2015-date Fri Jan 23 15:26:28 2015; exit: 0 0 0
140.53_RunHI2011+RunHI2011+RECOHID11+HARVESTDHI Step0-PASSED Step1-PASSED Step2-PASSED  - time date Fri Jan 23 15:43:24 2015-date Fri Jan 23 15:26:29 2015; exit: 0 0 0
1330.0_ZMM_13+ZMM_13+DIGIUP15+RECOUP15+HARVESTUP15+MINIAODMCUP15 Step0-PASSED Step1-PASSED Step2-PASSED Step3-PASSED Step4-PASSED  - time date Fri Jan 23 15:58:00 2015-date Fri Jan 23 15:39:44 2015; exit: 0 0 0 0 0
1000.0_RunMinBias2011A+RunMinBias2011A+TIER0+SKIMD+HARVESTDfst2+ALCASPLIT Step0-PASSED Step1-PASSED Step2-PASSED Step3-PASSED Step4-PASSED  - time date Fri Jan 23 15:59:07 2015-date Fri Jan 23 15:43:34 2015; exit: 0 0 0 0 0
1001.0_RunMinBias2011A+RunMinBias2011A+TIER0EXP+ALCAEXP+ALCAHARVD Step0-PASSED Step1-PASSED Step2-PASSED Step3-PASSED  - time date Fri Jan 23 15:57:55 2015-date Fri Jan 23 15:47:24 2015; exit: 0 0 0 0
10 10 9 7 6 tests passed, 0 0 0 0 0 failed

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_4_X IBs unless changes or unless it breaks tests.

@slava77
Copy link
Contributor

slava77 commented Jan 23, 2015

right, your description is correct.

On 1/23/15 9:30 AM, Salvatore Di Guida wrote:

@slava77 https://github.com/slava77
When you say

|the easiest testing of 6x6 APE payloads for us would be to be able to show identical results incrementally
...
after this PR is integrated, #6978 can be tested incrementally
|

I assume that the incremental test you want to do is the following:

  1. you run the tests with the new GT in the latest IB, and check the
    output: this should not give you changes in DIGI-RECO (apart EE in
    Run2 startup due to misalignment) as the additional records are not
    consumed, and the old ones are kept unchanged.
  2. you then run the tests with the new GT on top of Migration to 6x6 APE matrix in alignment and RECO #6978
    Migration to 6x6 APE matrix in alignment and RECO #6978 : it should return the
    same values.

—
Reply to this email directly or view it on GitHub
#7339 (comment).

Vyacheslav (Slava) Krutelyov
TAMU: Physics Dept Texas A&M MS4242, College Station, TX 77843-4242
CERN: 42-R-027
AIM/Skype: siava16 googleTalk: slava77@gmail.com
(630) 291-5128 Cell (US) +41 76 275 7116 Cell (CERN)

@cmsbuild
Copy link
Contributor

+1
Tested at: f23d6af
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-7339/2075/summary.html

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_4_X IBs unless changes (tests are also fine). This pull request will be automatically merged.

cmsbuild added a commit that referenced this pull request Jan 23, 2015
@cmsbuild
Merge pull request #7339 from diguida/autoCond_740pre6
b1ee9c1 
New Global Tags for Release Validation in all the supported scenarios.
@cmsbuild cmsbuild merged commit b1ee9c1 into cms-sw:CMSSW_7_4_X Jan 23, 2015
@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-7339/2075/summary.html

@diguida diguida mentioned this pull request Jan 23, 2015
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
alca-approved comparison-pending fully-signed tests-approved
Projects
None yet
Milestone
Next CMSSW_7_4_X
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@diguida @cmsbuild @davidlange6 @slava77