Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removed unnecessary mutable keyword from PerformancePayloadFromTFormula #7396

Merged
merged 1 commit into from Jan 28, 2015
Merged

Removed unnecessary mutable keyword from PerformancePayloadFromTFormula #7396

merged 1 commit into from Jan 28, 2015

Conversation

Dr15Jones
Copy link
Contributor

The static analyzer complained about the existence of a non-thread
safe class being used as a mutable. Since the mutable keyword was
not necessary (the variable is never changed in a const member function)
it was removed.

@Dr15Jones
Removed unnecessary mutable keyword
47b77d8 
The static analyzer complained about the existence of a non-thread
safe class being used as a mutable. Since the mutable keyword was
not necessary (the variable is never changed in a const member function)
it was removed.
@cmsbuild cmsbuild added this to the Next CMSSW_7_4_X milestone Jan 27, 2015
@cmsbuild
Copy link
Contributor

A new Pull Request was created by @Dr15Jones (Chris Jones) for CMSSW_7_4_X.

Removed unnecessary mutable keyword from PerformancePayloadFromTFormula

It involves the following packages:

CondFormats/PhysicsToolsObjects

@diguida, @cerminar, @cmsbuild, @nclopezo, @rcastello, @ggovi, @mmusich can you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.

@ghost
Copy link

ghost commented Jan 28, 2015

@cmsbuild please test

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

+1
Tested at: 47b77d8
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-7396/2173/summary.html

@Dr15Jones
Copy link
Contributor Author

@ktf this change is trivial

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-7396/2173/summary.html

@Dr15Jones
Copy link
Contributor Author

@ktf this change was trivial.

@diguida
Copy link
Contributor

diguida commented Jan 28, 2015

+1

ktf added a commit that referenced this pull request Jan 28, 2015
@ktf
Merge pull request #7396 from Dr15Jones/removeUnneededMutableFromPerf…
612508b 
…ormancePayloadFromTFormula

Removed unnecessary mutable keyword from PerformancePayloadFromTFormula
@ktf ktf merged commit 612508b into cms-sw:CMSSW_7_4_X Jan 28, 2015
@Dr15Jones Dr15Jones deleted the removeUnneededMutableFromPerformancePayloadFromTFormula branch February 25, 2015 20:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
alca-approved comparison-available db-pending pending-signatures tests-approved
Projects
None yet
Milestone
Next CMSSW_7_4_X
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Dr15Jones @cmsbuild @diguida @ktf