Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make OmniClusterRef data private #7397

Merged
merged 1 commit into from Jan 29, 2015
Merged

Conversation

wddgit
Copy link
Contributor

@wddgit wddgit commented Jan 27, 2015

No description provided.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @wddgit (W. David Dagenhart) for CMSSW_7_4_X.

Make OmniClusterRef data private

It involves the following packages:

DataFormats/TrackerRecHit2D

@cmsbuild, @cvuosalo, @nclopezo, @slava77 can you please review it and eventually sign? Thanks.
@makortel, @VinInn this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.

@ghost
Copy link

ghost commented Jan 28, 2015

@cmsbuild please test

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

@cvuosalo
Copy link
Contributor

+1

For #7397 adcbfb9

Very tiny change of making a data member private. Change could only affect compilation, and compilation test is successful. Other tests are fine, as expected.

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_4_X IBs unless changes (tests are also fine). This pull request will be automatically merged.

cmsbuild added a commit that referenced this pull request Jan 29, 2015
Make OmniClusterRef data private
@cmsbuild cmsbuild merged commit 762675b into cms-sw:CMSSW_7_4_X Jan 29, 2015
@wddgit wddgit deleted the omniClusterRef branch May 19, 2015 19:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants