Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pilot Electronics Material #7420

Merged
merged 3 commits into from Jan 30, 2015
Merged

Pilot Electronics Material #7420

merged 3 commits into from Jan 30, 2015

Conversation

ianna
Copy link
Contributor

@ianna ianna commented Jan 28, 2015

@ianna
Copy link
Contributor Author

ianna commented Jan 28, 2015

+1

@cmsbuild cmsbuild added this to the Next CMSSW_7_4_X milestone Jan 28, 2015
@cmsbuild
Copy link
Contributor

A new Pull Request was created by @ianna (Ianna Osborne) for CMSSW_7_4_X.

Pilot Electronics Material

It involves the following packages:

Geometry/CMSCommonData
Geometry/TrackerCommonData
Validation/Geometry

@cmsbuild, @danduggan, @nclopezo, @deguio can you please review it and eventually sign? Thanks.
@ghellwig, @makortel, @VinInn this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.

@ghost
Copy link

ghost commented Jan 28, 2015

@cmsbuild please test

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

+1
Tested at: 5784729
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-7420/2192/summary.html

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-7420/2192/summary.html

@deguio
Copy link
Contributor

deguio commented Jan 30, 2015

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_4_X IBs unless changes (tests are also fine). This pull request will be automatically merged.

cmsbuild added a commit that referenced this pull request Jan 30, 2015
@cmsbuild
Merge pull request #7420 from friccita/PilotElectronicsMaterial
8cccc67 
Pilot Electronics Material
@cmsbuild cmsbuild merged commit 8cccc67 into cms-sw:CMSSW_7_4_X Jan 30, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
comparison-available dqm-approved fully-signed geometry-approved tests-approved
Projects
None yet
Milestone
Next CMSSW_7_4_X
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@ianna @cmsbuild @deguio @friccita