Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run jet reco properly on miniAOD #7482

Merged
merged 3 commits into from Feb 4, 2015

Conversation

rappoccio
Copy link
Contributor

This PR adds a bunch of changes necessary to run jet reco properly on miniAOD. There are a number of small changes related to using pat::Jets instead of reco::PFJets, and also generalized the input of PFCandidate to simply Candidate into the jet software to allow for pat::PackedCandidates.

Tests with the matrix worked for "-l limited" and "-l 1341.0". Also checked "scram b runtests" and that was also successful.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @rappoccio for CMSSW_7_4_X.

Run jet reco properly on miniAOD

It involves the following packages:

CommonTools/RecoAlgos
DataFormats/PatCandidates
RecoJets/JetProducers

@nclopezo, @cvuosalo, @monttj, @cmsbuild, @slava77, @vadler can you please review it and eventually sign? Thanks.
@TaiSakuma, @ahinzmann, @yslai, @nhanvtran, @schoef, @mariadalfonso this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.

@slava77
Copy link
Contributor

slava77 commented Jan 30, 2015

@cmsbuild please test

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

@slava77
Copy link
Contributor

slava77 commented Feb 4, 2015

+1

for #7482 f5ef097

based on jenkins tests: there are no differences in reco outputs now;
I also looked at the PAT file outputs for 4.53 (Photon in 2012B): they seem to have ~the same size (patPackedCandidates_packedPFCandidates__PAT is the only branch with tiny changes, by 58 bytes or 0.5%; could be just a compression thing)

@monttj
Copy link
Contributor

monttj commented Feb 4, 2015

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 4, 2015

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_4_X IBs unless changes (tests are also fine). This pull request will be automatically merged.

cmsbuild added a commit that referenced this pull request Feb 4, 2015
@cmsbuild cmsbuild merged commit 29298c7 into cms-sw:CMSSW_7_4_X Feb 4, 2015
@rappoccio rappoccio deleted the RecoJetsFromMiniAOD branch April 22, 2015 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants