Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated PATSecondaryVertexSlimmer #7493

Conversation

ferencek
Copy link
Contributor

@ferencek ferencek commented Feb 1, 2015

PATSecondaryVertexSlimmer now works with candidate-based IVF secondary vertices produced in the standard Reco in 74X and stores them in MiniAOD with re-keyed Ptrs to PackedCandidates. The old mode with reco::Vertex IVF vertices is still supported but not used by default.

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 1, 2015

A new Pull Request was created by @ferencek (Dinko Ferencek) for CMSSW_7_4_X.

Updated PATSecondaryVertexSlimmer

It involves the following packages:

PhysicsTools/PatAlgos

@cmsbuild, @vadler, @nclopezo, @monttj can you please review it and eventually sign? Thanks.
@rappoccio, @imarches, @ahinzmann, @acaudron, @mmarionncern, @nhanvtran, @schoef, @ferencek, @mariadalfonso, @pvmulder, @TaiSakuma this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 2, 2015

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 2, 2015

@ferencek
Copy link
Contributor Author

ferencek commented Feb 2, 2015

@cmsbuild please re-test

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 2, 2015

Pull request #7493 was updated. @cmsbuild, @vadler, @nclopezo, @monttj can you please check and sign again.

@ferencek
Copy link
Contributor Author

ferencek commented Feb 2, 2015

Actually, this one will now need to go after #7488 since it requires 74X RelVals.

@monttj
Copy link
Contributor

monttj commented Feb 3, 2015

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 3, 2015

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_4_X IBs unless changes or unless it breaks tests.

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 4, 2015

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 4, 2015

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_4_X IBs unless changes (tests are also fine). This pull request will be automatically merged.

cmsbuild added a commit that referenced this pull request Feb 4, 2015
…W_7_4_0_pre6

Updated PATSecondaryVertexSlimmer
@cmsbuild cmsbuild merged commit e5ffabd into cms-sw:CMSSW_7_4_X Feb 4, 2015
@ferencek ferencek deleted the CandIVFVtxSlimmer_from-CMSSW_7_4_0_pre6 branch February 4, 2015 18:12
@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 4, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants