Critical revision of the CASTOR monitor package... + postprocessing + hiding 4 histograms #7499
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CastorDataIntegrityMonitor These files were intended to be removed, but somehow ended up being just "empty". The files still existed, but had no content and size 0.
New deleting the different sub modules in the destructor.
Removed beginJob and placed content in dqmbeginrun (since it needs iSetup) Removed endJob and also removed the corresponding done() methods in the subclasses. Only one of these done() had content, which was stricly verbose output.
cmsbuild
added
comparison-pending
dqm-pending
pending-signatures
tests-started
and removed
dqm-pending
pending-signatures
tests-pending
labels
|
+1 |
cmsbuild
removed
comparison-pending
dqm-pending
pending-signatures
tests-approved
labels
|
This pull request is fully signed and it will be integrated in one of the next CMSSW_7_4_X IBs unless changes (tests are also fine). This pull request will be automatically merged. |
cmsbuild
added a commit
that referenced
this pull request
Feb 2, 2015
Critical revision of the CASTOR monitor package... + postprocessing + hiding 4 histograms
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR supersedes #7365
We additionally commented away 4 very large histograms.
... so that at least this PR can be accepted and in a later stage the 4 histograms can be added again in a "smaller" version.