New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update MEt Phi correction factors from CVS HEAD #750
Update MEt Phi correction factors from CVS HEAD #750
Conversation
I would say "-1" for this. CVS HEAD changes the user interface and is not compatible with the development that I am working on now. The most recent correction constants were merged without changing the interface: Please contact me if this commit needs to be merged. |
Indeed, it's much easier to simply update the corrections factor. I'll cherry-pick your commit on this branch and update my PR. |
Thank you. |
Done. |
I see. I didn't notice that you are requesting for CMSSW_5_3_X. Yesterday, I included this commit in the MET recipe for 53X. I am curious if the cms-merge-topic in the recipe will succeed if this commit is merged in the cms-sw/cmssw. |
@TaiSakuma |
@vadler, I am "+1" for this. |
A new Pull Request was created by @blinkseb (Sébastien Brochet) for CMSSW_5_3_X. Update MEt Phi correction factors from CVS HEAD It involves the following packages: JetMETCorrections/Type1MET @vadler can you please review it and eventually sign? Thanks. |
+1 |
This pull request is fully signed and it will be integrated in one of the next IBs unless changes or unless it breaks tests. @smuzaffar can you please take care of it? |
+1 |
1 similar comment
+1 |
Update MEt Phi correction factors from CVS HEAD
This PR update the MEt Phi correction factors with latest version taken from CVS HEAD. It was not tagged and therefore lost during the git transition.
It includes correction factors for Run2012 ABCD (ReReco) and Summer 13 JEC.
It's simply a backport of #739.