Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update MEt Phi correction factors from CVS HEAD #750

Merged

Conversation

blinkseb
Copy link
Contributor

@blinkseb blinkseb commented Sep 9, 2013

This PR update the MEt Phi correction factors with latest version taken from CVS HEAD. It was not tagged and therefore lost during the git transition.

It includes correction factors for Run2012 ABCD (ReReco) and Summer 13 JEC.

It's simply a backport of #739.

@TaiSakuma
Copy link
Contributor

I would say "-1" for this.

CVS HEAD changes the user interface and is not compatible with the development that I am working on now.

The most recent correction constants were merged without changing the interface:
#739

Please contact me if this commit needs to be merged.

@blinkseb
Copy link
Contributor Author

blinkseb commented Sep 9, 2013

Indeed, it's much easier to simply update the corrections factor. I'll cherry-pick your commit on this branch and update my PR.

@TaiSakuma
Copy link
Contributor

Thank you.

@blinkseb
Copy link
Contributor Author

blinkseb commented Sep 9, 2013

Done.

@TaiSakuma
Copy link
Contributor

I see. I didn't notice that you are requesting for CMSSW_5_3_X.

Yesterday, I included this commit in the MET recipe for 53X.
https://twiki.cern.ch/twiki/bin/view/CMSPublic/SWGuideMETRecipe53X

I am curious if the cms-merge-topic in the recipe will succeed if this commit is merged in the cms-sw/cmssw.

@vadler
Copy link

vadler commented Sep 10, 2013

@TaiSakuma
So, what is your conclusion on this one?

@TaiSakuma
Copy link
Contributor

@vadler, I am "+1" for this.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @blinkseb (Sébastien Brochet) for CMSSW_5_3_X.

Update MEt Phi correction factors from CVS HEAD

It involves the following packages:

JetMETCorrections/Type1MET

@vadler can you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.

@cmsbuild
Copy link
Contributor

Pull request #750 was updated. @vadler, @nclopezo can you please check and sign again.

@vadler
Copy link

vadler commented Sep 27, 2013

+1
Finally not much left to test.

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next IBs unless changes or unless it breaks tests. @smuzaffar can you please take care of it?

@fabiocos
Copy link
Contributor

fabiocos commented Oct 4, 2013

+1

1 similar comment
@smuzaffar
Copy link
Contributor

+1

smuzaffar added a commit that referenced this pull request Oct 4, 2013
Update MEt Phi correction factors from CVS HEAD
@smuzaffar smuzaffar merged commit 603c6a0 into cms-sw:CMSSW_5_3_X Oct 4, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants