Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add most CSC changes to the run2 era #7506

Merged

Conversation

mark-grimes
Copy link

This is another pull request to split up #6784 and apply it incrementally. This part deals with most of the CSC customisations. #7500 and #7503 are associated but are for different packages. Each of these pull requests can be merged individually.

Note that none of these changes have any effect unless the run2 era is explicitly used. Details on how to do that are on #7500.

There are still some CSC customisations to move from the helper customisation to the era. I need to check the overlap with trigger code and I'll move those in a subsequent pull request. As mentioned on #7500, the changes in the first commit (22f41e2) are just to update for external changes to the customisations in the last week, and not strictly related to this change (but still required).

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 2, 2015

A new Pull Request was created by @mark-grimes (Mark Grimes) for CMSSW_7_4_X.

Add most CSC changes to the run2 era

It involves the following packages:

CalibMuon/CSCCalibration
EventFilter/CSCRawToDigi
Geometry/CSCGeometryBuilder
RecoLocalMuon/CSCRecHitD
SLHCUpgradeSimulations/Configuration
SimMuon/CSCDigitizer

@civanch, @diguida, @cvuosalo, @ianna, @mdhildreth, @cmsbuild, @Dr15Jones, @cerminar, @slava77, @mmusich, @ktf, @nclopezo can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @bellan, @ghellwig, @barvic this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.

@slava77
Copy link
Contributor

slava77 commented Feb 2, 2015

@cmsbuild please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 2, 2015

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 3, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants