Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use of pf-based b-taggers in DQM #7507

Merged
merged 3 commits into from Feb 3, 2015

Conversation

acaudron
Copy link

@acaudron acaudron commented Feb 2, 2015

Switch to pf-based taggers in the b-tagging DQM for fullsim and data as it will be default for Run2.
It's also making possible the reading of the b-tagging information from MiniAOD as only pf-based taggers are supported.
No change for fastsim as the results with the pf-based taggers are not as expected. There is more to understand there before swiching taggers also for fastsim.

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 2, 2015

A new Pull Request was created by @acaudron for CMSSW_7_4_X.

Use of pf-based b-taggers in DQM

It involves the following packages:

DQMOffline/RecoB
Validation/RecoB

@cmsbuild, @danduggan, @nclopezo, @deguio can you please review it and eventually sign? Thanks.
@ferencek, @acaudron, @rociovilar, @pvmulder, @imarches this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.

@davidlange6
Copy link
Contributor

@cmsbuild please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 3, 2015

The tests are being triggered in jenkins.

@acaudron
Copy link
Author

acaudron commented Feb 3, 2015

FastSim issue was related to: https://hypernews.cern.ch/HyperNews/CMS/get/famos/631.html
So testing on new IBs, it's now working fine. The update is then to finalize the switch to the pf-based taggers.

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 3, 2015

Pull request #7507 was updated. @cmsbuild, @danduggan, @nclopezo, @deguio can you please check and sign again.

@deguio
Copy link
Contributor

deguio commented Feb 3, 2015

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 3, 2015

@deguio
Copy link
Contributor

deguio commented Feb 3, 2015

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 3, 2015

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_4_X IBs unless changes (tests are also fine). This pull request will be automatically merged.

cmsbuild added a commit that referenced this pull request Feb 3, 2015
@cmsbuild cmsbuild merged commit 9ed6599 into cms-sw:CMSSW_7_4_X Feb 3, 2015
@ferencek ferencek deleted the pfBasedBtagDQM branch February 4, 2015 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants