DT migration to MT. was #6360

[deguio]

this is the migration to MT framework for the DT code.
@fcavallo

[deguio]

please test

[cmsbuild]

The tests are being triggered in jenkins.

[cmsbuild]

A new Pull Request was created by @deguio for CMSSW_7_4_X.

Pull request for dt

It involves the following packages:

DQM/DTMonitorClient
DQM/DTMonitorModule

@cmsbuild, @danduggan, @nclopezo, @deguio can you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.

[cmsbuild]

+1
Tested at: 9ac076a
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-7510/2300/summary.html

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-7510/2300/summary.html

[deguio]

+1
this PR is huge and can be merged as it is now. few minor details will be fixed with another PR in the next days.
the code runs and no regression is observed. it still needs to be tested for what concerns the online environment.

@fcavallo @vanbesien @battibass

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_4_X IBs unless changes (tests are also fine). This pull request will be automatically merged.

[Dr15Jones]

@deguio
We need to have the DTDataIntegrityTask to be set as thread unsafe since it manipulates many statics. From the static analyzer report:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/ib-static-analysis/CMSSW_7_4_X_2015-02-04-0200/slc6_amd64_gcc491/reports/modules2statics.txt

you'll find entries like
In call stack ' DTDataIntegrityTask::analyze() calls function DTDataIntegrityTask::processROS25() calls function ROSWords_t() static variable ResetCount_unfolded_comp' is accessed , 'DTDataIntegrityTask::analyze()' overrides 'edm::stream::EDAnalyzerBase::analyze() virtual'

The statics can all be seen here
http://cmslxr.fnal.gov/source/DQM/DTMonitorModule/src/ROSDebugUtility.h?v=CMSSW_7_4_X_2015-02-04-0200

[deguio]

thanks chris. added to my todo list.
sorry about that.
F.

[dmitrijus]

Fixed, #7619.