Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Candidate-based SL taggers, CSV+SL tagger, and c-tagger #7542

Conversation

ferencek
Copy link
Contributor

@ferencek ferencek commented Feb 3, 2015

This PR introduces candidate-based and retrained soft lepton taggers. In addition, it introduces config files for a PF-based CSV+SL tagger and a PF-based c-taggers. Since the global tag containing calibration records for the CSV+SL and c-tagger is not yet ready, the taggers are temporarily commented out.

We undertstand that 740pre7 is the last open pre-release and therefore all the final taggers were supposed to be included in it, but certain things were simply out of our control and we did not manage to have everything ready by the deadline.

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 3, 2015

A new Pull Request was created by @ferencek (Dinko Ferencek) for CMSSW_7_4_X.

Candidate-based SL taggers, CSV+SL tagger, and c-tagger

It involves the following packages:

DQMOffline/RecoB
DataFormats/BTauReco
PhysicsTools/PatAlgos
RecoBTag/Configuration
RecoBTag/SecondaryVertex
RecoBTag/SoftLepton
RecoVertex/AdaptiveVertexFinder

@nclopezo, @cvuosalo, @monttj, @cmsbuild, @deguio, @slava77, @vadler, @danduggan can you please review it and eventually sign? Thanks.
@TaiSakuma, @imarches, @makortel, @acaudron, @mmarionncern, @GiacomoSguazzoni, @rappoccio, @rovere, @VinInn, @appeltel, @ahinzmann, @nhanvtran, @schoef, @ferencek, @cerati, @mariadalfonso, @pvmulder, @dgulhan, @rociovilar this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.

@deguio
Copy link
Contributor

deguio commented Feb 3, 2015

+1
DQM slightly touched

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 4, 2015

-1

Tested at: 5f64032
I ran the usual tests and I found errors in the following unit tests:

---> test runtestPhysicsToolsPatAlgos had ERRORS

you can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-7542/2338/summary.html

@cmsbuild
Copy link
Contributor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

10 participants