Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updates to pairing logic: paring PU samples according to PU scenario #7575

Merged
merged 1 commit into from Feb 5, 2015

Conversation

anorkus
Copy link
Contributor

@anorkus anorkus commented Feb 5, 2015

Automatic pairing update to pair PU samples with same PU scenario when all the ROOT files are in same directory.

Signed-off-by: Antanas Norkus antanas.norkus@cern.ch

Signed-off-by: Antanas Norkus <antanas.norkus@cern.ch>
@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 5, 2015

A new Pull Request was created by @anorkus (Antanas Norkus) for CMSSW_7_4_X.

updates to pairing logic: paring PU samples according to PU scenario

It involves the following packages:

Utilities/RelMon

@cmsbuild, @cvuosalo, @nclopezo, @slava77 can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @wddgit this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 5, 2015

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 5, 2015

@slava77
Copy link
Contributor

slava77 commented Feb 5, 2015

+1

for #7575 a58597d

@nclopezo which RelMon version does jenkins pick up to run comparisons when a PR with a change in RelMon comes up?

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 5, 2015

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_4_X IBs unless changes (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @ktf, @smuzaffar

@davidlange6
Copy link
Contributor

+1

@nclopezo
Copy link
Contributor

nclopezo commented Feb 6, 2015

Hi @slava77,

It always uses the version from the IB that is being used to run the tests. So in this case it used the version from CMSSW_7_4_X_2015-02-05-0200. I can change it if you want.

@slava77
Copy link
Contributor

slava77 commented Feb 6, 2015

Hi David,
It's a bit recursive here, since it introduces a need to compare comparison tool :)
It would be more practical to run RelMon twice in this case, once for the IB and once for the IB+PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants