Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ROOT does not use u or l qualifiers for template paramaters in class nam... #7607

Merged
merged 1 commit into from Feb 6, 2015

Conversation

wmtan
Copy link
Contributor

@wmtan wmtan commented Feb 6, 2015

This is a bug fix to allow putting a ROOT SMatrix in an event, as requested by Slava Krutelyov. ROOT does not use u or l qualifiers for the names of integer template parameters in class names. Because of this, a missing dictionary error resulted when attempting put an SMatrix into an event. This pull request adds stripping off the "u" or "l" qualifiers in class names containing integer template parameters, thereby correcting the error.
This is the pull request for the CMSSW_7_4_ROOT6_X branch only. The same fix was requested for 7_4_X in a different pull request, due to previous differences in the two branches.
Please merge this request as soon as convenient.

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 6, 2015

A new Pull Request was created by @wmtan for CMSSW_7_4_ROOT6_X.

ROOT does not use u or l qualifiers for template paramaters in class nam...

It involves the following packages:

FWCore/Utilities

@cmsbuild, @Dr15Jones, @ktf, @nclopezo can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @wddgit this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.

@ktf
Copy link
Contributor

ktf commented Feb 6, 2015

Root6 only. Merging.

ktf added a commit that referenced this pull request Feb 6, 2015
ROOT does not use u or l qualifiers for template paramaters in class nam...
@ktf ktf merged commit 85a9cae into cms-sw:CMSSW_7_4_ROOT6_X Feb 6, 2015
@wmtan wmtan deleted the RemoveULQualifiersROOT6 branch February 6, 2015 22:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants