Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migration to consumes -- CSCRawToDigi #763

Closed
wants to merge 16 commits into from

Conversation

ptcox
Copy link
Contributor

@ptcox ptcox commented Sep 10, 2013

Adds consumes interface to 6 files in CSCRawToDigi that need it. Several untested since their config files are out of date, but seemed sensible to update the code anyway.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @ptcox for CMSSW_7_0_X.

Consumes to CSCRawToDigi

It involves the following packages:

RecoLocalMuon/CSCValidation
EventFilter/CSCRawToDigi

@thspeer, @slava77 can you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.

@thspeer
Copy link
Contributor

thspeer commented Sep 11, 2013

Working @thspeer

@thspeer
Copy link
Contributor

thspeer commented Sep 12, 2013

+1
No change in reco, as expected
Tested b49cb73 in CMSSW_7_0_X_2013-09-11-0200-763

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next IBs unless changes or unless it breaks tests.

@ktf
Copy link
Contributor

ktf commented Sep 13, 2013

Moving this to pre5 since it needs to be rebased.

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next IBs unless changes or unless it breaks tests. @ktf can you please take care of it?

@ktf ktf closed this Sep 27, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants