Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

std::regex_replace not supported in gcc4.8.1 #7635

Merged

Conversation

wmtan
Copy link
Contributor

@wmtan wmtan commented Feb 9, 2015

A recent fix caused a compilation error in gcc4.8.1 because std::regex_replace() does not appear to be supported there. This pull request simply replaces this use of std::regex with boost::regex.

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 9, 2015

A new Pull Request was created by @wmtan for CMSSW_7_4_X.

std::regex_replace not supported in gcc4.8.1

It involves the following packages:

FWCore/Utilities

@cmsbuild, @Dr15Jones, @ktf, @nclopezo can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @wddgit this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@Dr15Jones
Copy link
Contributor

please test

@Dr15Jones
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 9, 2015

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 9, 2015

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_4_X IBs unless changes or unless it breaks tests. This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @ktf, @smuzaffar

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 9, 2015

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_4_X IBs unless changes or unless it breaks tests. This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @ktf, @smuzaffar

davidlange6 added a commit that referenced this pull request Feb 9, 2015
std::regex_replace not supported in gcc4.8.1
@davidlange6 davidlange6 merged commit 24d224a into cms-sw:CMSSW_7_4_X Feb 9, 2015
@wmtan wmtan deleted the stdRegexReplaceNotSupportedIngcc481 branch February 9, 2015 20:34
@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 9, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants