New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make EgHLTTrigCodes non-static. #7637
Conversation
Now it is instantiated once(!), by EgHLTOfflineSource. Everyone who uses it gets a read-only reference. Made EgHLTMonElemFuncs to be a proper class, to help passing parameters around.
A new Pull Request was created by @dmitrijus (Dmitrijus) for CMSSW_7_4_X. Make EgHLTTrigCodes non-static. It involves the following packages: DQMOffline/Trigger @cmsbuild, @danduggan, @nclopezo, @deguio can you please review it and eventually sign? Thanks. |
Looks good to me |
please test |
The tests are being triggered in jenkins. |
+1 |
thanks @dmitrijus |
This pull request is fully signed and it will be integrated in one of the next CMSSW_7_4_X IBs unless changes (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @ktf, @smuzaffar |
+1 |
Make EgHLTTrigCodes non-static.
Now it is instantiated once(!), by EgHLTOfflineSource.
Everyone who uses it gets a read-only reference.
Made EgHLTMonElemFuncs to be a proper class,
to help passing parameters around.
Please test/review before accepting.
(Followup of #7360)