Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Made static inside BitSet::bits const #7641

Merged
merged 1 commit into from Feb 10, 2015

Conversation

Dr15Jones
Copy link
Contributor

The static array used inside of BitSet::bits was never begin modified
so made it const. This was spotted by the static analyzer.

The static array used inside of BitSet::bits was never begin modified
so made it const. This was spotted by the static analyzer.
@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 9, 2015

A new Pull Request was created by @Dr15Jones (Chris Jones) for CMSSW_7_4_X.

Made static inside BitSet::bits const

It involves the following packages:

PhysicsTools/MVAComputer

@cmsbuild, @vadler, @nclopezo, @monttj can you please review it and eventually sign? Thanks.
@ferencek, @acaudron, @pvmulder, @imarches this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@davidlange6
Copy link
Contributor

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

davidlange6 added a commit that referenced this pull request Feb 10, 2015
Made static inside BitSet::bits const
@davidlange6 davidlange6 merged commit 43a2e1f into cms-sw:CMSSW_7_4_X Feb 10, 2015
@cmsbuild
Copy link
Contributor

@Dr15Jones Dr15Jones deleted the constBitSetBits branch April 7, 2015 20:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants