Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more muon changes to the run2 era #7729

Merged

Conversation

mark-grimes
Copy link

Moves the last of the CSC configuration changes for Run 2 from the helper function to the run2 era.

Changes to cscTriggerPrimitiveDigis and csctfTrackDigis (and by extension simCscTriggerPrimitiveDigis and simCsctfTrackDigis) are made in the files themselves rather than the sister files

L1Trigger/CSCTriggerPrimitives/python/cscTriggerPrimitiveDigisPostLS1_cfi.py
L1Trigger/CSCTrackFinder/python/csctfTrackDigisUngangedME1a_cfi.py

(i.e. those files are not used for the era). Once the era has been fully validated and workflows switched to using it I recommend deleting the above two files.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @mark-grimes (Mark Grimes) for CMSSW_7_4_X.

Add more muon changes to the run2 era

It involves the following packages:

L1Trigger/CSCTrackFinder
L1Trigger/CSCTriggerPrimitives
SLHCUpgradeSimulations/Configuration
SimMuon/Configuration

@cmsbuild, @civanch, @nclopezo, @mulhearn, @mdhildreth can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @valuev, @abbiendi, @trocino, @battibass this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@mark-grimes
Copy link
Author

Testing has been limited, although there are no changes unless the run2 era is explicitly activated. I just made sure everything parses and the particular changes take effect. I'll do full comparisons between the customisation and era output once all the pull requests are in.

@davidlange6
Copy link
Contributor

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

@davidlange6
Copy link
Contributor

bypassing era PRs until everything is working (no effect on workflows for now)

davidlange6 added a commit that referenced this pull request Feb 15, 2015
@davidlange6 davidlange6 merged commit 5e3553d into cms-sw:CMSSW_7_4_X Feb 15, 2015
@mark-grimes mark-grimes deleted the convertPostLS1ToEra_muons2 branch August 3, 2015 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants