New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add more muon changes to the run2 era #7729
Add more muon changes to the run2 era #7729
Conversation
A new Pull Request was created by @mark-grimes (Mark Grimes) for CMSSW_7_4_X. Add more muon changes to the run2 era It involves the following packages: L1Trigger/CSCTrackFinder @cmsbuild, @civanch, @nclopezo, @mulhearn, @mdhildreth can you please review it and eventually sign? Thanks. |
Testing has been limited, although there are no changes unless the run2 era is explicitly activated. I just made sure everything parses and the particular changes take effect. I'll do full comparisons between the customisation and era output once all the pull requests are in. |
@cmsbuild, please test |
The tests are being triggered in jenkins. |
bypassing era PRs until everything is working (no effect on workflows for now) |
Add more muon changes to the run2 era
Moves the last of the CSC configuration changes for Run 2 from the helper function to the
run2
era.Changes to
cscTriggerPrimitiveDigis
andcsctfTrackDigis
(and by extensionsimCscTriggerPrimitiveDigis
andsimCsctfTrackDigis
) are made in the files themselves rather than the sister files(i.e. those files are not used for the era). Once the era has been fully validated and workflows switched to using it I recommend deleting the above two files.