Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

puppi bug fix 73x from JOtt #7735

Merged
merged 1 commit into from Feb 19, 2015

Conversation

nhanvtran
Copy link
Contributor

PUPPI bug fix for 73x too.

Is this okay?

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @nhanvtran for CMSSW_7_3_X.

puppi bug fix 73x from JOtt

It involves the following packages:

CommonTools/PileupAlgos

@nclopezo, @cvuosalo, @monttj, @cmsbuild, @slava77, @vadler can you please review it and eventually sign? Thanks.
@ahinzmann, @rappoccio this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@nclopezo you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@cvuosalo
Copy link
Contributor

@cmsbuild please test

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

@cvuosalo
Copy link
Contributor

+1

For #7735 2ef660b

Identical to #7733, except intended for 7_3_X rather than 7_4_X, this PR makes small code changes to protect against a possible division by zero and a possible negative array index reference. Prior to this fix, programs that encountered these special situations would probably have crashed.

Jenkins tests show no problems or differences, but this PR would not be expected to cause any change in program behavior except in the very rare cases where the particular situations it protects against occur.

@slava77
Copy link
Contributor

slava77 commented Feb 16, 2015

is bot asleep? there was a +1 from reco

@slava77
Copy link
Contributor

slava77 commented Feb 17, 2015

+1

trying to convince cms-bot
#7735 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants