Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow reading of files written with ROOT6 in ROOT5 #7736

Merged
merged 1 commit into from Feb 14, 2015

Conversation

wmtan
Copy link
Contributor

@wmtan wmtan commented Feb 13, 2015

Bug fix: In ROOT6, the normalized names of three data types were changed from what they were in ROOT5. (unsigned) long long was changed to (U)Long64_t, and std::basic_string was changed to std::string. Because these names affect branch names, this creates an incompatibility between ROOT5 and ROOT6. The backward compatibility issue (reading ROOT5 files in ROOT6) was fixed a long time ago. However, at that time, I did not realize that ROOT provided the ability to read files written with ROOT6 in ROOT5. So, the compatibility fix was needed in the ROOT5 release as well.
Without this fix, ROOT/EDM files written in ROOT6 that contain a top level data item of any of the three affected types, OR of any type templated over these types (e.g. a vector of one of them) cannot be read in ROOT5.
Note: This fix is already in CMSSW_7_4_ROOT6_X.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @wmtan for CMSSW_7_4_X.

Allow reading of files written with ROOT6 in ROOT5

It involves the following packages:

FWCore/Utilities

@cmsbuild, @Dr15Jones, @ktf, @nclopezo can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @wddgit this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@Dr15Jones
Copy link
Contributor

Please test

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.

@Dr15Jones
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_4_X IBs unless changes or unless it breaks tests. This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @ktf, @smuzaffar

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_4_X IBs unless changes (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @ktf, @smuzaffar

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_4_X IBs unless changes (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @ktf, @smuzaffar

@davidlange6
Copy link
Contributor

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants