New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow reading of files written with ROOT6 in ROOT5 #7736
Conversation
A new Pull Request was created by @wmtan for CMSSW_7_4_X. Allow reading of files written with ROOT6 in ROOT5 It involves the following packages: FWCore/Utilities @cmsbuild, @Dr15Jones, @ktf, @nclopezo can you please review it and eventually sign? Thanks. |
Please test |
The tests are being triggered in jenkins. |
+1 |
This pull request is fully signed and it will be integrated in one of the next CMSSW_7_4_X IBs unless changes or unless it breaks tests. This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @ktf, @smuzaffar |
This pull request is fully signed and it will be integrated in one of the next CMSSW_7_4_X IBs unless changes (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @ktf, @smuzaffar |
This pull request is fully signed and it will be integrated in one of the next CMSSW_7_4_X IBs unless changes (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @ktf, @smuzaffar |
+1 |
Allow reading of files written with ROOT6 in ROOT5
Bug fix: In ROOT6, the normalized names of three data types were changed from what they were in ROOT5. (unsigned) long long was changed to (U)Long64_t, and std::basic_string was changed to std::string. Because these names affect branch names, this creates an incompatibility between ROOT5 and ROOT6. The backward compatibility issue (reading ROOT5 files in ROOT6) was fixed a long time ago. However, at that time, I did not realize that ROOT provided the ability to read files written with ROOT6 in ROOT5. So, the compatibility fix was needed in the ROOT5 release as well.
Without this fix, ROOT/EDM files written in ROOT6 that contain a top level data item of any of the three affected types, OR of any type templated over these types (e.g. a vector of one of them) cannot be read in ROOT5.
Note: This fix is already in CMSSW_7_4_ROOT6_X.