Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

renamed functions to access PAT isolation variables to avoid conflict wi... #7764

Merged

Conversation

cmsbuild
Copy link
Contributor

The functions to access the pat::Photon userIsolation were identically named to the reco::Photon ones.
This was confusing, requiring the users to type reco::Photon::FunctionName() whenever they wanted to access the reco::Photon isolation values.
Now the accessors have been renamed with "pat" in front, to avoid the conflict.
Automatically ported from CMSSW_7_4_X #7761

@cmsbuild
Copy link
Contributor Author

A new Pull Request was created by @cmsbuild for CMSSW_7_5_X.

renamed functions to access PAT isolation variables to avoid conflict wi...

It involves the following packages:

DataFormats/PatCandidates

@cmsbuild, @vadler, @nclopezo, @monttj can you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@nclopezo, @ktf you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@cmsbuild
Copy link
Contributor Author

@cmsbuild
Copy link
Contributor Author

davidlange6 added a commit that referenced this pull request Feb 21, 2015
…h_reco

renamed functions to access PAT isolation variables to avoid conflict wi...
@davidlange6 davidlange6 merged commit 9ec4a8c into cms-sw:CMSSW_7_5_X Feb 21, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants