Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix wrong import in metFilters_cff #779

Merged
merged 1 commit into from Sep 11, 2013

Conversation

blinkseb
Copy link
Contributor

This is #757 for CMSSW 7.0.x

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @blinkseb (Sébastien Brochet) for CMSSW_7_0_X.

Fix wrong import in metFilters_cff

It involves the following packages:

RecoMET/METFilters

@vadler can you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.

@vadler
Copy link

vadler commented Sep 11, 2013

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next IBs unless changes or unless it breaks tests.

@ktf
Copy link
Contributor

ktf commented Sep 11, 2013

I guess this is not exercised by the matrix otherwise we would have spotted it right?

ktf added a commit that referenced this pull request Sep 11, 2013
Fix wrong import in metFilters_cff
@ktf ktf merged commit 1418e02 into cms-sw:CMSSW_7_0_X Sep 11, 2013
@vadler
Copy link

vadler commented Sep 16, 2013

IIRC, there is also no integration test for that.

@TaiSakuma
Copy link
Contributor

How can we add an integration test and an exercise to the matrix?

@blinkseb blinkseb deleted the 7x_fix_met_filters branch September 17, 2013 12:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants