Added handling of special case of OTMB corrupted data to the CSC binary examiner

[barvic]

Added handling of special case of OTMB corrupted data to the CSC binary Examiner as part of the CSC Unpacker.

• The issue was reported by RECO developers during processing of PromptReco MinimumBias job with the release CMSSW_7_3_2_patch1
• The assertion was triggered in CSC unpacker code for Run 234107 MinimumBias data
• Was caused by special case of corrupted data from OTMB board, which wasn't marked as bad by the CSC examiner
• Current fix is to detect and mark such data as bad and then reject such bad events from further unpacking

[cmsbuild]

A new Pull Request was created by @barvic for CMSSW_7_3_X.

Added handling of special case of OTMB corrupted data to the CSC binary examiner

It involves the following packages:

EventFilter/CSCRawToDigi

@cmsbuild, @cvuosalo, @nclopezo, @slava77 can you please review it and eventually sign? Thanks.
@Martin-Grunewald this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@nclopezo you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

[cmsbuild]

+1
Tested at: e79619c
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-7829/2694/summary.html

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-7829/2694/summary.html

[cvuosalo]

+1

For #7829 e79619c

This PR fixes a rare assertion failure in the CSC unpacker that occurs due to corruption in the data stream that occurs under unusual circumstances.

The code change is satisfactory, and all Jenkins tests show no differences, as expected.

A test case that reproduced the assertion failure in CMSSW_7_3_2_patch1 worked correctly without failure with the new code.

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_3_X IBs unless changes (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @nclopezo, @ktf, @smuzaffar

[davidlange6]

+1