Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Gem geometry payload #786

Merged
merged 3 commits into from Sep 12, 2013
Merged

Gem geometry payload #786

merged 3 commits into from Sep 12, 2013

Conversation

ianna
Copy link
Contributor

@ianna ianna commented Sep 11, 2013

  • GEM reco ideal geometry payload loader. Migrated from CVS HEAD. It was tagged, but never released.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @ianna for CMSSW_7_0_X.

Gem geometry payload

It involves the following packages:

CondTools/Geometry

@ggovi, @apfeiffer1 can you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.

@nclopezo
Copy link
Contributor

Hi,

I ran the usual tests on top of CMSSW_7_0_X_2013-09-11-0200, all tests passed:

https://cmssdt.cern.ch/jenkins/job/Pull-Request-Integration/ARCHITECTURE=slc5_amd64_gcc481/457/console

you can see the artifacts here:

https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/457

ktf
ktf reviewed Sep 11, 2013
View reviewed changes
CondTools/Geometry/plugins/GEMRecoIdealDBLoader.cc

GEMRecoIdealDBLoader::GEMRecoIdealDBLoader(const edm::ParameterSet& iConfig) : label_()
{
std::cout<<"GEMRecoIdealDBLoader::GEMRecoIdealDBLoader"<<std::endl;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any reason for not using LogDebug?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This code is not used in standard workflows.

@ianna ianna closed this Sep 12, 2013
@ianna ianna reopened this Sep 12, 2013
@cmsbuild
Copy link
Contributor

Pull request #786 was updated. @ggovi, @apfeiffer1 can you please check and sign again.

@nclopezo
Copy link
Contributor

Hi,
I tested this pull request again with the new commit, all test passed. You can see the logs here:

https://cmssdt.cern.ch/jenkins/job/Pull-Request-Integration/ARCHITECTURE=slc5_amd64_gcc481/465/console

@apfeiffer1
Copy link
Contributor

+1
then.

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next IBs unless changes or unless it breaks tests.

ktf added a commit that referenced this pull request Sep 12, 2013
@ktf
Merge pull request #786 from ianna/gem-geometry-payload
0d0b818 
Gem geometry payload
@ktf ktf merged commit 0d0b818 into cms-sw:CMSSW_7_0_X Sep 12, 2013
@ianna ianna deleted the gem-geometry-payload branch October 26, 2015 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
fully-signed
Projects
None yet
Milestone
CMSSW_7_0_0_pre4
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@ianna @cmsbuild @nclopezo @apfeiffer1 @ktf