New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added default ctors to embedded classes to avoid unit test crashing #7892
Conversation
A new Pull Request was created by @apfeiffer1 (Andreas Pfeiffer) for CMSSW_7_5_X. added default ctors to embedded classes to avoid unit test crashing It involves the following packages: CondFormats/L1TObjects @diguida, @cerminar, @cmsbuild, @nclopezo, @ggovi, @mmusich, @mulhearn can you please review it and eventually sign? Thanks. |
+1 |
This pull request is fully signed and it will be integrated in one of the next CMSSW_7_5_X IBs unless changes (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @nclopezo, @ktf, @smuzaffar |
+1 |
added default ctors to embedded classes to avoid unit test crashing
Sounds like this fixes for ROOT6 which is still 7_4_X. |
Yes, but a PR for this was just merged into 7_4_X. That will take care of ROOT6. |
for some reason unknown to me, the serialisation unit test of this package crashes in the 74x-ROOT6 IB (though not in the regular IB).
This PR fixes the crash by adding default ctors to the embedded classes in the CaloParams class which initialise the members.