Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added default ctors to embedded classes to avoid unit test crashing #7892

Merged
merged 1 commit into from Mar 4, 2015

Conversation

apfeiffer1
Copy link
Contributor

for some reason unknown to me, the serialisation unit test of this package crashes in the 74x-ROOT6 IB (though not in the regular IB).

This PR fixes the crash by adding default ctors to the embedded classes in the CaloParams class which initialise the members.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @apfeiffer1 (Andreas Pfeiffer) for CMSSW_7_5_X.

added default ctors to embedded classes to avoid unit test crashing

It involves the following packages:

CondFormats/L1TObjects

@diguida, @cerminar, @cmsbuild, @nclopezo, @ggovi, @mmusich, @mulhearn can you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@nclopezo, @ktf you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@cmsbuild
Copy link
Contributor

@mulhearn
Copy link
Contributor

mulhearn commented Mar 2, 2015

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 4, 2015

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_5_X IBs unless changes (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @nclopezo, @ktf, @smuzaffar

@davidlange6
Copy link
Contributor

+1

@Dr15Jones
Copy link
Contributor

Sounds like this fixes for ROOT6 which is still 7_4_X.

@wmtan
Copy link
Contributor

wmtan commented Mar 4, 2015

Yes, but a PR for this was just merged into 7_4_X. That will take care of ROOT6.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants